Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update magic-string due to deprecated dependency #146

Merged
merged 2 commits into from
Dec 6, 2022

Conversation

jperelli
Copy link
Contributor

@jperelli jperelli commented Dec 5, 2022

npm i throws this warning

...
npm WARN deprecated sourcemap-codec@1.4.8: Please use @jridgewell/sourcemap-codec instead
...

npm ls sourcemap-codec says

└─┬ @sentry/esbuild-plugin@0.2.3
  └─┬ @sentry/bundler-plugin-core@0.2.3
    └─┬ magic-string@0.26.2
      └── sourcemap-codec@1.4.8

magic-string module CHANGELOG.md does not look like is making a breaking change from 0.26.2 to 0.27.0

@lforst
Copy link
Member

lforst commented Dec 5, 2022

Thanks for the PR! I am gonna do some manual tests here to verify this isn't actually breaking something. Just as a heads-up, minor version bumps on 0.x are actually considered breaking semver-spec wise.

@lforst lforst merged commit f98523b into getsentry:main Dec 6, 2022
@lforst
Copy link
Member

lforst commented Dec 6, 2022

Looks all good! Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants