fix(core): Finish spans when CLI commands fail #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
approved these changes
Nov 25, 2022
| try { | ||
| await ctx.cli.releases.new(releaseName); | ||
| } finally { | ||
| span?.finish(); |
There was a problem hiding this comment.
we really need a top level span method...
Lms24
reviewed
Nov 25, 2022
Comment on lines
40
to
+46
| const span = addSpanToTransaction(ctx, "function.plugin.clean_artifacts"); | ||
|
|
||
| await ctx.cli.releases.execute(["releases", "files", releaseName, "delete", "--all"], true); | ||
| try { | ||
| await ctx.cli.releases.execute(["releases", "files", releaseName, "delete", "--all"], true); | ||
| } finally { | ||
| span?.finish(); | ||
| } |
There was a problem hiding this comment.
Don't we put span onto the scope in addSpanToTransaction? In case we do, can we finish the span in the try/catch/finally that wraps the entire release creation pipeline?
There was a problem hiding this comment.
I had that before but it felt very blanket-approachy. I like this more because it is more explicit (though admittedly repetitive).
There was a problem hiding this comment.
Fair enough, was just a thought 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes telemetry by finishing spans after CLI commands fail.