Skip to content

docs: Add examples to individual READMEs #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 14, 2022
Merged

docs: Add examples to individual READMEs #115

merged 3 commits into from
Nov 14, 2022

Conversation

@lforst
Copy link

@lforst lforst commented Nov 14, 2022

Resolves #114

Adds examples to the READMEs of the individual bundlers.

@lforst lforst requested a review from Lms24 November 14, 2022 12:12
Lms24
Lms24 approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m: In all "Usage" sections, we should probably add, in which file these modifications should happen, right? For Vite e.g. in vite.config.js, etc.

Otherwise 🚀

@lforst lforst enabled auto-merge (squash) November 14, 2022 12:21
@lforst lforst merged commit 2df1ece into main Nov 14, 2022
@lforst lforst deleted the lforst-readme-examples branch November 14, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lms24 Lms24 Lms24 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update READMEs to include examples

3 participants

@lforst @Lms24