Skip to content

Conversation

@Lms24
Copy link
Member

@Lms24 Lms24 commented Nov 11, 2022

⚠️ Needs Discussion!

We currently send the org and project as tags in each error or transaction to Sentry (if telemetry is enabled). Furthermore, we also set the user to org.

This PR would remove all mentions or org and project in Sentry events. Happy to merge it if we say that this is necessary.

ref: #99

@Lms24 Lms24 changed the title ref(core): Don't send org and project to Sentry ref(core): Don't send org and project to Sentry Nov 11, 2022
@Lms24 Lms24 requested review from mydea and smeubank November 11, 2022 11:02
@vladanpaunovic
Copy link
Contributor

I find this information valuable as we could literally reach out to affected people and help them resolve the issue. On top of that, this could help us group issues and discover patterns on the user level, which in this context here is the organisation.

In my opinion, it is safe to assume that there is a consent as this is under the user opted in flag telemetry and is being delivered to us only for those users who opt out for using it.

@mydea
Copy link
Member

mydea commented Nov 11, 2022

I find this information valuable as we could literally reach out to affected people and help them resolve the issue. On top of that, this could help us group issues and discover patterns on the user level, which in this context here is the organisation.

In my opinion, it is safe to assume that there is a consent as this is under the user opted in flag telemetry and is being delivered to us only for those users who opt out for using it.

AFAIK this is currently not opt-in, but opt-out, meaning by default it will be on for all users.
Just thinking, what about making the telemetry option an enum instead of a boolean? Then we could do e.g.:

// all: Send full telemetry data, including org name
// minimal: default option, send basic telemetry data, excluding org name.
// off: No telemetry data sent
type TelemetryOption = 'all' | 'minimal' | 'off';

@Lms24
Copy link
Member Author

Lms24 commented Nov 11, 2022

I'm waiting on a for a reply in #discuss-legal on this. If we have to make changes, the enum type would probably be a good solution, with the minimal option as a default

@Lms24 Lms24 marked this pull request as draft November 11, 2022 16:06
@Lms24 Lms24 closed this Nov 15, 2022
@Lms24
Copy link
Member Author

Lms24 commented Nov 15, 2022

Closing in favour of #120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants