Skip to content

Conversation

@markushi
Copy link
Member

@markushi markushi commented Nov 3, 2025

Summary

  • Add screenshot strategy serialization to RRWeb options events
  • Maps PIXEL_COPY screenshot strategy to "pixelCopy" and defaults to "canvas"
  • Updates test fixture to include the new field

Test plan

  • Updated test JSON fixture with expected screenshot strategy value
  • Verify serialization logic correctly handles both strategy types

Serialize the screenshot strategy from replay options in RRWeb events,
mapping PIXEL_COPY to "pixelCopy" and defaulting to "canvas".

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against aa2cf20

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 316.02 ms 365.30 ms 49.28 ms
Size 1.58 MiB 2.12 MiB 551.55 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
27d7cf8 397.90 ms 498.65 ms 100.75 ms
9fbb112 361.43 ms 427.57 ms 66.14 ms
b3d8889 371.33 ms 426.24 ms 54.92 ms
b3d8889 420.46 ms 453.71 ms 33.26 ms
d217708 355.34 ms 381.39 ms 26.05 ms
27d7cf8 314.17 ms 347.00 ms 32.83 ms
ee747ae 396.82 ms 441.67 ms 44.86 ms
3d205d0 352.15 ms 432.53 ms 80.38 ms
85d7417 347.21 ms 394.35 ms 47.15 ms
d5a29b6 298.62 ms 391.78 ms 93.16 ms

App size

Revision Plain With Sentry Diff
27d7cf8 1.58 MiB 2.12 MiB 549.42 KiB
9fbb112 1.58 MiB 2.11 MiB 539.18 KiB
b3d8889 1.58 MiB 2.10 MiB 535.07 KiB
b3d8889 1.58 MiB 2.10 MiB 535.07 KiB
d217708 1.58 MiB 2.10 MiB 532.97 KiB
27d7cf8 1.58 MiB 2.12 MiB 549.42 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
3d205d0 1.58 MiB 2.10 MiB 532.97 KiB
85d7417 1.58 MiB 2.10 MiB 533.44 KiB
d5a29b6 1.58 MiB 2.12 MiB 549.37 KiB

Previous results on branch: feat/rrweb-screenshot-strategy

Startup times

Revision Plain With Sentry Diff
88722ce 308.94 ms 355.16 ms 46.23 ms
4bd0606 310.92 ms 346.12 ms 35.21 ms

App size

Revision Plain With Sentry Diff
88722ce 1.58 MiB 2.12 MiB 551.56 KiB
4bd0606 1.58 MiB 2.12 MiB 551.55 KiB

@markushi markushi enabled auto-merge (squash) November 3, 2025 09:28
@markushi markushi merged commit ab8a72d into main Nov 3, 2025
61 checks passed
@markushi markushi deleted the feat/rrweb-screenshot-strategy branch November 3, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants