feat(replay): Adding OkHttp Request/Response bodies #4796

43jay · 2025-10-09T21:27:58Z

📜 Description

Initalise DefaultReplayBreadcrumbConverter as the SDK-wide BeforeBreadcrumbCallback. It is responsible for delegating to a user-provided BeforeBreadcrumb.

Introduce new utility/data classes (io.sentry.util.network pkg), following format in the javascript SDK.

In BeforeBreadcrumb, NetworkDetailCaptureUtils extracts 'Network Details' data objects (NetworkRequestData, ReplayNetworkRequestOrResponse) and inserts back into the breadcrumb Hint (only sentry-okhttp for now).

When converting Breadcrumb to RRWebSpanEvent, extract NetworkRequestData data from Hint (name="replay:networkDetails") and insert into the replay performanceSpan when creating the replay segment.

TODOs

Feedback:

Are we handling 'enough' body types? Given there are so many diff types of request bodies ->
Current impl handles JSON, UrlFormEncoded, skips these binary content types, and falls back to raw String as possible
Decide on keeping changes to sentry-samples-android
Will this work when the gradle plugin is used to add the SentryOkHttpInterceptor? This code implies we only send the breadcrumb w/ network details when that path isn't active.

Implementation:

Restrict size of breadcrumbsMap entries after data has been added to replay
Respect networkDetail* SDK Options flags
- Will handle in a Future PR
handle case where SentryOkHttpEventListener handles http request instrumentation
- Will handle in a Future PR
More unit tests after addressing the PR feedback, e.g.:
- SentryOkHttpInterceptor
- AndroidOptionsInitializer
- NetworkBodyParser (at least the json part)

Pre-Land:

Go through commits and remove any testing-oriented ones
- Remove FAKE_OPTIONS in SentryOkHttpInterceptor before landing // there for testing
Remove remaining unnecessary debug log statements

💡 Motivation and Context

Part of [Mobile Replay] Capture Network request/response bodies

Initially, we were trying to keep SDK changes simple and re-use the existing OKHTTP_REQUEST|RESPONSE hint data.
However, the :sentry-android-replay gradle module doesn't compile against any of the http libs (makes sense).

Because these okhttp3.Request, etc types don't exist in :sentry-android-replay, replay accesses the NetworkDetails data via Hint data ("replay:networkDetails") on the Breadcrumb, when the SDKOptions constraints have been met.

💚 How did you test it?

DefaultReplayBreadcrumbConverterTest unit tests:

./gradlew clean :sentry-android-replay:testDebugUnitTest --no-build-cache --rerun-tasks --tests="DefaultReplayBreadcrumbConverterTest"

Manually creating replay sessions:

this replay session is an example recording with no networkDetail* SDK options enabled
(replay sessions below were captured without commit 4bc5b7714).

recording segment data shows sample replay payload .

replay session respects networkDetail[Request|Response]Headers

https://sentry-sdks.sentry.io/explore/replays/f89535ea0e79499ca8d75e34e6270925

replay session captures GET request bodies as null

replay session

replay session captures JSON bodies

1. Request body formatted as JSON key/values
ref

2. Response body formatted as JSON key/values
ref

replay session captures plaintext bodies

replay session

replay session captures form bodies (formurlencoded)

replay session

replay session captures binary bodies

1. binary body under size limit (valid response size; summarized body content

https://sentry-sdks.sentry.io/explore/replays/baf899dd12c14718bc5d8b877a9fff3d

2. binary body over size limit (invalid response size, summarized body content
(https://sentry-sdks.sentry.io/explore/replays/94dc96ae2b8c4f4d8c23e2e0c69e5d1d)

replay session truncates plaintext bodies over 150KB (`MAX_NETWORK_BODY_SIZE`)

https://sentry-sdks.sentry.io/explore/replays/e11711a70c164a8fa1a2ed39e8632a05

replay sessions properly capture one-shot okhttp request bodies

One-shot HTTP Request Body request

Test: read(..) okhttp3.Request.body in an OkHttpInterceptor after cloning body into new request causes the request to succeed ✅ (current impl)

replay session

Valid response body logged to sentry:

Sanity Test: read(..) okhttp3.Request.body in an OkHttpInterceptor without cloning body into a new request causes the request to fail ✅

replay session

Invalid response body logged to sentry:

https://sentry-sdks.sentry.io/settings/projects/sentry-android/keys/

…dcrumbCallback to extract NetworkRequestData from Hint -> NetworkRequestData is landing on DefaultReplayBreadcrumbConverter via Hint.get(replay:networkDetails)

linear · 2025-10-09T21:28:02Z

MOBILE-935 [Mobile Replay] Capture Network request/response bodies

...ry-android-replay/src/main/java/io/sentry/android/replay/DefaultReplayBreadcrumbConverter.kt

sentry-android-core/src/main/java/io/sentry/android/core/AndroidOptionsInitializer.java

sentry-okhttp/src/main/java/io/sentry/okhttp/SentryOkHttpInterceptor.kt

...ry-android-replay/src/main/java/io/sentry/android/replay/DefaultReplayBreadcrumbConverter.kt

These get set on the breadcrumb Hint, and then hang around in DefaultReplayBreadcrumbConverter until the replay segment has been sent off See https://github.com/getsentry/sentry-javascript/blob/632f0b953d99050c11b0edafb9f80b5f3ba88045/packages/replay-internal/src/types/performance.ts#L133-L140 https://github.com/getsentry/sentry-javascript/blob/develop/packages/replay-internal/src/types/request.ts#L12

Manually set networkDetailHasUrls to pass this check https://github.com/getsentry/sentry-javascript/blob/d1646c8a281dd8795c5a6a3b8e18f2e7069e7fa9/packages/replay-internal/src/util/handleRecordingEmit.ts#L134 https://github.com/getsentry/sentry/blob/master/static/app/views/replays/detail/network/details/getOutputType.tsx#L33 https://github.com/getsentry/sentry/blob/master/static/app/views/replays/detail/network/details/content.tsx#L55-L56

added some unit tests: ./gradlew :sentry-android-replay:testDebugUnitTest --tests="*DefaultReplayBreadcrumbConverterTest*"

Breadcrumb.java has several timestamp fields: `timestamp: Date`, `timestampMs: Long`, `nanos: Long` `hashcode` was relying solely on `timestamp`, which can be null depending on which constructor was used. => Change to use getTimestamp as 1. this is what equals does (consistency) 2. getTimestamp initialises timestamp if null.

sentry/src/main/java/io/sentry/rrweb/RRWebOptionsEvent.java

seer-by-sentry · 2025-10-24T15:53:09Z

...ry-android-replay/src/main/java/io/sentry/android/replay/DefaultReplayBreadcrumbConverter.kt

+  private val httpNetworkDetails =
+    Collections.synchronizedMap(
+      object : LinkedHashMap<Breadcrumb, NetworkRequestData>() {
+        override fun removeEldestEntry(
+          eldest: MutableMap.MutableEntry<Breadcrumb, NetworkRequestData>?
+        ): Boolean {
+          return size > MAX_HTTP_NETWORK_DETAILS
+        }
+      }
+    )


Bug: Breadcrumb.equals() omits data map, causing HashMap key collisions for concurrent requests, leading to incorrect network data attribution.
_{Severity: CRITICAL | Confidence: 1.00}

🔍 Detailed Analysis

The Breadcrumb.equals() method omits the data map from its comparison. This allows distinct Breadcrumb objects, particularly those generated by HTTP requests occurring within the same millisecond but having different URLs or other data map contents, to be considered equal. When these Breadcrumb objects are used as keys in the httpNetworkDetails LinkedHashMap, one entry can unintentionally overwrite another, causing network details from one request to be incorrectly associated with a different request during session replay processing.

💡 Suggested Fix

Modify Breadcrumb.equals() to include the data map in its comparison, or use a different key for httpNetworkDetails that uniquely identifies each network request, such as a UUID or a composite key including relevant data fields.

🤖 Prompt for AI Agent

Fix this bug. In sentry-android-replay/src/main/java/io/sentry/android/replay/DefaultReplayBreadcrumbConverter.kt at lines 33-42: The `Breadcrumb.equals()` method omits the `data` map from its comparison. This allows distinct `Breadcrumb` objects, particularly those generated by HTTP requests occurring within the same millisecond but having different URLs or other `data` map contents, to be considered equal. When these `Breadcrumb` objects are used as keys in the `httpNetworkDetails` `LinkedHashMap`, one entry can unintentionally overwrite another, causing network details from one request to be incorrectly associated with a different request during session replay processing.

_{Did we get this right? 👍 / 👎 to inform future reviews.}

@romtsn is there any issue with updating Breadcrumb#equals and Breadcrumb#hashmap to include data in the comparison?

I left it out in my commit cuz assumed we want Breadcrumbs to be equal if they have different data (e.g. it's the same breadcrumb if some more data gets added by a different caller at some point later)

hmm, that's a tricky one. The problem with data is that people tend to put there any kind of stuff and it can be a deeply-nested data structure which will result in a super expensive equals/hashCode call, so I think doing this generally for all breadcrumbs is gonna backfire.

I guess I see 3 options to address this:

Override contains/equals for the LinkedHashMap.Entry (if possible), and define our equals logic there specifically for http breadcrumbs

Introduce a transient id to the Breadcrumb object and use it for comparison (or use it as a key in the httpNetworkDetails dictionary)

Switch the entire approach to always rely on BeforeBreadcrumbCallback, i.e. we wouldn't grab the breadcrumbs from the Scope here, but instead store them from within our ReplayBeforeBreadcrumbCallback directly and use it later for creating a segment/sending to Sentry. That way we wouldn't need to associate crumbs <-> hints, as we would have them in one place. But that's certainly a bigger lift

Maybe there's some other option I didn't think of - let me know!

Okay, yeah - i see there will be an issue if multiple HTTP requests go out in the same millisecond, we will only record one of them.

Given it's an impl detail of Breadcrumb, which already has helpers to create http breadcrumbs - wyt about adding custom equals/hashcode logic for http breadcrumb i.e. something like

@Override public boolean equals(Object o) { if (this == o) return true; if (o == null || getClass() != o.getClass()) return false; Breadcrumb that = (Breadcrumb) o; switch (type) { case 'http': return httpBreadcrumbEquals(this, that); default: return breadcrumbEquals(this, that); } } private static boolean breadcrumbEquals(Breadcrumb a, Breadcrumb b) { return a.getTimestamp().getTime() == that.getTimestamp().getTime() && Objects.equals(message, that.message) && Objects.equals(type, that.type) && Objects.equals(category, that.category) && Objects.equals(origin, that.origin) && level == that.level; } private static boolean httpBreadcrumbEquals(Breadcrumb a, Breadcrumb b) { return breadcrumbEquals(a, b) && a.getData("status_code") == b.getData("status_code") && a.getData("url") == b.getData("url") && a.getData("method") == b.getData("method") && a.getData("http.fragment") == b.getData("http.fragment") && a.getData("http.query") == b.getData("http.query") }

sentry-android-core/src/main/java/io/sentry/android/core/AndroidOptionsInitializer.java

...ry-android-replay/src/main/java/io/sentry/android/replay/DefaultReplayBreadcrumbConverter.kt

Entrypoint is NetworkDetailCaptureUtils (initializeForUrl) called from SentryOkHttpInterceptor - common logic to handle checking sdk options. - Accept data from http client via NetworkBodyExtractor, NetworkHeaderExtractor interfaces that can be reused in future (if needed) Placeholder impl for req/resp bodies. From https://docs.sentry.io/platforms/javascript/session-replay/configuration/ - networkDetailAllowUrls, networkDetailDenyUrls, - networkCaptureBodies - networkRequestHeaders, networkResponseHeaders These SDKOptions don't exist yet => impl acts as if they do, but have not been enabled.

This reverts commit ca28040.

This reverts commit b8555e2.

romtsn · 2025-10-29T16:27:16Z

sentry/src/main/java/io/sentry/ReplayBreadcrumbConverter.java

 import org.jetbrains.annotations.NotNull;
 import org.jetbrains.annotations.Nullable;

+/**


so I brainstormed this a bit, and thinking if it'd make more sense to use composition here -- currently this is a breaking binary change for our hybrid SDKs (RN and Flutter that inherit from DefaultReplayBreadcrumbConverter). I was thinking of ways to avoid the breaking change and came up with the following:

public open class DefaultReplayBreadcrumbConverter() : ReplayBreadcrumbConverter { private var options: SentryOptions? = null public constructor(options: SentryOptions) : this() { this.options = options this.options?.beforeBreadcrumb = ReplayBeforeBreadcrumbCallback(options.beforeBreadcrumb) } private class ReplayBeforeBreadcrumbCallback( val delegate: BeforeBreadcrumbCallback? ) : BeforeBreadcrumbCallback { override fun execute(breadcrumb: Breadcrumb, hint: Hint): Breadcrumb? { TODO() } }

this way the hybrid SDKs wouldn't be broken once we ship this and they'd be just missing on the native req/resp bodies because they are not using the new ctor with options. Once they use the new ctor they automatically would get req/resp bodies for okhttp-originated requests. Wdyt?

romtsn · 2025-10-29T16:33:31Z

sentry-android-core/src/main/java/io/sentry/android/core/AndroidOptionsInitializer.java

      options.setCompositePerformanceCollector(new DefaultCompositePerformanceCollector(options));
    }

+    ReplayBreadcrumbConverter replayBreadcrumbConverter = options.getReplayController().getBreadcrumbConverter();


I think this currently has a bug if someone excludes the -replay module from the build, then this would return a NoOpReplayBreadcrumbConverter implementation which does not currently delegate to the user-defined beforeBreadcrumb callback. So we'd be effectively swallowing the breadcrumb in here.

Given my comment here, if we go for that impl, we could change to instantiating and setting DefaultReplayBreadcrumbConverter here:

final @NotNull converter = options.getReplayController().getBreadcrumbConverter(); if (converter instanceof NoOpReplayBreadcrumbConverter) { options.getReplayController().setBreadcrumbConverter(new DefaultReplayBreadcrumbConverter(options)); }

I guess we still have to check for no-op here, because RN and Flutter define their own converters, e.g. see this, so we shouldn't be overwriting whatever they have set.

makes a lot of sense!

It looks tho like the sdk always overrides the NoopBreadcrumbConverter =>
instanceof NoOpReplayBreadcrumbConverter here will always returns false.
(^? this is what i was uncertain of... but reading the code and adding a log line here confirms at least for my test app)

One option: unwind that behaviour by moving the DefaultReplayBreadcrumbConverter initialization out of installDefaultIntegrations so that the instanceof NoOpReplayBreadcrumbConverter can evaluate to true here + DefaultReplayBreadcrumbConverter can be initialized here.

Alternatively, leave that code alone (which effectively means the NoOpReplayBreadcrumbConverter is dead code? unless there are tests, or other configurations that don't come through installDefaultIntegrations🤔): instead refactor the DefaultReplayBreadcrumbConverter to have post-initialization logic something like

final @NotNull beforeBreadcrumb = options.getReplayController().getBreadcrumbConverter().getBeforeBreadcrumb(); if (beforeBreadcrumb == null) { options.getReplayController().getBreadcrumbConverter() .setBeforeBreadcrumb(new ReplayBeforeBreadcrumbCallback(options)); }

Moving the initialization of DefaultReplayBreadcrumbConverter out of installDefaultIntegrations entirely and depending on instanceof NoOpReplayBreadcrumbConverter seems cleaner (first option).

Assuming the initialization was put there b/c previously DefaultReplayBreadcrumbConverter was independent of SDKOptions... but "now it is" => move the entire thing out, instead of try to keep some initialization in installDefaultIntegrations and then do some more initialization later (here in initializeIntegrationsAndProcessors).

I've started working on this (and the refactor to use composition to not change the ReplayBreadcrumbConverter API as well)... any idea if there were other motivations for putting DefaultReplayBreadcrumbConverter initialization inside installDefaultIntegrations, that moving it down to initializeIntegrationsAndProcessors could break?

romtsn · 2025-10-29T17:26:02Z

sentry/src/main/java/io/sentry/SentryReplayOptions.java

+  /**
+   * Maximum size in bytes for network request/response bodies to be captured in replays. Bodies
+   * larger than this will be truncated or replaced with a placeholder message. Default is 150KB
+   * (153600 bytes).


Suggested change

* (153600 bytes).

* (153600 bytes).

* Aligned with JS: https://github.com/getsentry/sentry-javascript/blob/98de756506705b60d1ca86cbbcfad3fd76062f8f/packages/replay-internal/src/constants.ts#L33

maybe worth linking the JS part here?

sentry/src/main/java/io/sentry/util/network/NetworkBody.java

romtsn · 2025-10-29T17:30:51Z

sentry/src/main/java/io/sentry/util/network/NetworkBody.java

+   * @param value The map representing the JSON object
+   * @return A NetworkBody instance for the JSON object
+   */
+  static @NotNull NetworkBody fromJsonObject(@NotNull Map<String, Object> value) {


so we have a tendency to mark all parameters (and members) as final everywhere - would you mind following that pattern? We probably should've adopted checkstyle's FinalParam check a long time ago 😅

romtsn · 2025-10-30T10:45:53Z

sentry-okhttp/src/main/java/io/sentry/okhttp/SentryOkHttpInterceptor.kt

+    /**
+     * Fake options for testing network detail capture
+     */
+    private val FAKE_OPTIONS = object {


I guess this will go away in a future PR, right?

yes my plan was to remove it in the next PR when I would introduce the actual SentryOptions API.

I can take it out and in-line emptyArray, etc everywhere if you think that's cleaner though?

romtsn · 2025-10-30T10:50:23Z

sentry-okhttp/src/main/java/io/sentry/okhttp/SentryOkHttpInterceptor.kt

+                safeExtractRequestBody(bodyBytes, originalBody.contentType())
+              } catch (e: Exception) {
+                scopes.options.logger.log(
+                  io.sentry.SentryLevel.DEBUG,


can we import this? Also, probably worth to change the level to WARNING or ERROR

romtsn · 2025-10-30T10:55:51Z

sentry-okhttp/src/main/java/io/sentry/okhttp/SentryOkHttpInterceptor.kt

+        response?.let { resp -> it[OKHTTP_RESPONSE] = resp }
+
+        if (networkDetailData != null) {
+          it.set("replay:networkDetails", networkDetailData)


maybe worth to add this to TypeCheckHint as a const? I'd also change it to sentry:replayNetworkDetails to align with other hint keys

romtsn · 2025-10-30T11:02:31Z

sentry-okhttp/src/main/java/io/sentry/okhttp/SentryOkHttpInterceptor.kt

  }

+  /** Extracts headers from OkHttp Headers object into a map */
+  private fun okhttp3.Headers.toMap(): Map<String, String> {


wondering if we can make this potentially faster with less allocations, e.g.:

private fun okhttp3.Headers.toMap(): Map<String, String> { val headers = LinkedHashMap<String, String>(size) for (i in 0 until size) { headers[name(i)] = value(i) } return headers }

still pending

romtsn · 2025-10-30T11:10:59Z

sentry-okhttp/src/main/java/io/sentry/okhttp/SentryOkHttpInterceptor.kt

+      )
+    } catch (e: Exception) {
+      scopes.options.logger.log(
+        io.sentry.SentryLevel.DEBUG,


probably also could be a warning or error

...ry-android-replay/src/main/java/io/sentry/android/replay/DefaultReplayBreadcrumbConverter.kt

romtsn · 2025-10-30T11:31:04Z

...ry-android-replay/src/main/java/io/sentry/android/replay/DefaultReplayBreadcrumbConverter.kt

+
+      // Original breadcrumb http data
      for ((key, value) in breadcrumb.data) {
        if (key in supportedNetworkData) {


i guess some of these keys can override what you set above right? (e.g. responseBodySize). But I guess it should be the same value, so doesn't matter much probably

that was my take as well - and left it in so that the old impl would 'win' in case there is some issue in the new one

romtsn

Looking great overall, hats off for all that different body types parsing logic! I left one overall design question and a few of nits.

Also, would be great to cover some of this with more tests after addressing the PR feedback, e.g.:

SentryOkHttpInterceptor
AndroidOptionsInitializer
NetworkBodyParser (at least the json part)

Claude decided to format these files ¯\_(ツ)_/¯

This reverts commit 4bc5b77.

use composition via optional constructor on DefaultReplayBreadcrumbConverter Instead of modifying the parent interface ReplayBreadcrumbConverter to force all subclasses to implement BeforeBreadcrumbCallback (breaking / harder to manage change)

…lization DefaultReplayBreadcrumbConverter depends on SDKOptions as it now needs to delegate to any user-provided BeforeBreadcrumbCallback

https://github.com/getsentry/sentry-java/pull/4796/files/6629e944e295c8b68a1f19cfc9525da9c2de0034#r2474338758

Also got rid of the VisibleForTesting constructor in NetworkRequestData review comment - https://github.com/getsentry/sentry-java/pull/4796/files#r2474350569

review comment - https://github.com/getsentry/sentry-java/pull/4796/files#r2477498463

Review comment- https://github.com/getsentry/sentry-java/pull/4796/files#r2477524631

This reverts commit 13c1da8.

cursor · 2025-11-04T21:29:35Z

sentry/src/main/java/io/sentry/util/network/NetworkBodyParser.java

+      return parse(content, contentType, logger);
+    } catch (UnsupportedEncodingException e) {
+      if (logger != null) {
+        logger.log(SentryLevel.WARNING, "Failed to decode bytes: " + e.getMessage());


Bug: API contract clash in NetworkBodyParser fromBytes

The NetworkBodyParser.fromBytes method's implementation takes an ILogger parameter, which conflicts with the public API contract expecting SentryOptions. This also creates an inconsistency where the @NotNull annotated logger parameter is unnecessarily null-checked within the method.

cursor · 2025-11-04T21:29:35Z

sentry/src/main/java/io/sentry/util/network/NetworkDetailCaptureUtils.java

+    // Only capture developer-provided urls.
+    if (networkDetailAllowUrls == null) {
+      return false;
+    }


Bug: Null-Driven URL Capture Mismatch in Javadoc

The shouldCaptureUrl method's Javadoc for networkDetailAllowUrls indicates null means "allow all", but the code treats null as "allow none". This prevents URL capture when networkDetailAllowUrls is not explicitly set.

Additional Locations (1)

sentry/src/main/java/io/sentry/util/network/NetworkDetailCaptureUtils.java#L83-L84

43jay added 5 commits October 7, 2025 14:33

Update dsn for testing

b8555e2

Enable replay verbose logging

ca28040

Point dsn to sentry-android project

5397e9d

https://sentry-sdks.sentry.io/settings/projects/sentry-android/keys/

Add HTTP Request Trigger to sentry-samples-android app

71ed70e

[replay] Make DefaultReplayBreadcrumbConverter the default BeforeBrea…

f2ce22e

…dcrumbCallback to extract NetworkRequestData from Hint -> NetworkRequestData is landing on DefaultReplayBreadcrumbConverter via Hint.get(replay:networkDetails)

43jay requested review from adinauer, lcian, markushi, romtsn and stefanosiano as code owners October 9, 2025 21:27

43jay marked this pull request as draft October 9, 2025 21:28

This comment was marked as outdated.

Sign in to view

seer-by-sentry bot reviewed Oct 9, 2025

View reviewed changes

...ry-android-replay/src/main/java/io/sentry/android/replay/DefaultReplayBreadcrumbConverter.kt Outdated Show resolved Hide resolved

sentry-android-core/src/main/java/io/sentry/android/core/AndroidOptionsInitializer.java Outdated Show resolved Hide resolved

romtsn reviewed Oct 13, 2025

View reviewed changes

sentry-okhttp/src/main/java/io/sentry/okhttp/SentryOkHttpInterceptor.kt Show resolved Hide resolved

romtsn reviewed Oct 13, 2025

View reviewed changes

sentry-okhttp/src/main/java/io/sentry/okhttp/SentryOkHttpInterceptor.kt Outdated Show resolved Hide resolved

romtsn reviewed Oct 13, 2025

View reviewed changes

sentry-okhttp/src/main/java/io/sentry/okhttp/SentryOkHttpInterceptor.kt Outdated Show resolved Hide resolved

romtsn reviewed Oct 13, 2025

View reviewed changes

...ry-android-replay/src/main/java/io/sentry/android/replay/DefaultReplayBreadcrumbConverter.kt Outdated Show resolved Hide resolved

43jay added 4 commits October 13, 2025 10:52

Move BeforeBreadcrumbCallback initialization to after user config

2d08e7b

added some unit tests: ./gradlew :sentry-android-replay:testDebugUnitTest --tests="*DefaultReplayBreadcrumbConverterTest*"

43jay changed the title ~~RFF(replay): Adding OkHttp Request/Response bodies for sentry-java~~ replay(feature): Adding OkHttp Request/Response bodies for sentry-java Oct 24, 2025

43jay commented Oct 24, 2025

View reviewed changes

sentry/src/main/java/io/sentry/rrweb/RRWebOptionsEvent.java Outdated Show resolved Hide resolved

43jay marked this pull request as ready for review October 24, 2025 15:50

seer-by-sentry bot reviewed Oct 24, 2025

View reviewed changes

This comment was marked as outdated.

Sign in to view

43jay commented Oct 24, 2025

View reviewed changes

sentry-android-core/src/main/java/io/sentry/android/core/AndroidOptionsInitializer.java Outdated Show resolved Hide resolved

43jay commented Oct 24, 2025

View reviewed changes

...ry-android-replay/src/main/java/io/sentry/android/replay/DefaultReplayBreadcrumbConverter.kt Outdated Show resolved Hide resolved

43jay added 2 commits October 27, 2025 17:19

Revert "Enable replay verbose logging"

a204a40

This reverts commit ca28040.

Revert "Update dsn for testing"

6629e94

This reverts commit b8555e2.

43jay requested a review from romtsn October 27, 2025 21:26

romtsn changed the title ~~replay(feature): Adding OkHttp Request/Response bodies for sentry-java~~ feat(replay): Adding OkHttp Request/Response bodies Oct 29, 2025

romtsn reviewed Oct 29, 2025

View reviewed changes

sentry/src/main/java/io/sentry/util/network/NetworkBody.java Show resolved Hide resolved

romtsn reviewed Oct 29, 2025

View reviewed changes

romtsn reviewed Oct 30, 2025

View reviewed changes

...ry-android-replay/src/main/java/io/sentry/android/replay/DefaultReplayBreadcrumbConverter.kt Outdated Show resolved Hide resolved

romtsn reviewed Oct 30, 2025

View reviewed changes

43jay added 12 commits November 4, 2025 12:21

Formatting / prettier

ef79439

Claude decided to format these files ¯\_(ツ)_/¯

Revert "Disable Network Detail extraction"

13c1da8

This reverts commit 4bc5b77.

Move ReplayBreadcrumbConverter initialization after SDKOptions initia…

c2e4477

…lization DefaultReplayBreadcrumbConverter depends on SDKOptions as it now needs to delegate to any user-provided BeforeBreadcrumbCallback

Fix up DefaultReplayBreadcrumbConverterTest

ad8e402

Make test names more meaningful

584df60

Formatter / prettify

9545155

Address reviewer comment

8c9333b

https://github.com/getsentry/sentry-java/pull/4796/files/6629e944e295c8b68a1f19cfc9525da9c2de0034#r2474338758

Make function parameters and class members final

bcb4efa

Also got rid of the VisibleForTesting constructor in NetworkRequestData review comment - https://github.com/getsentry/sentry-java/pull/4796/files#r2474350569

Log WARNING or ERROR instead of DEBUG and fix logger scope

38b8919

review comment - https://github.com/getsentry/sentry-java/pull/4796/files#r2477498463

Introduce SENTRY_REPLAY_NETWORK_DETAILS TypeCheckHint

b887de7

Review comment- https://github.com/getsentry/sentry-java/pull/4796/files#r2477524631

Reapply "Disable Network Detail extraction"

adb0482

This reverts commit 13c1da8.

cursor bot reviewed Nov 4, 2025

View reviewed changes

	* (153600 bytes).
	* (153600 bytes).
	* Aligned with JS: https://github.com/getsentry/sentry-javascript/blob/98de756506705b60d1ca86cbbcfad3fd76062f8f/packages/replay-internal/src/constants.ts#L33

Uh oh!

feat(replay): Adding OkHttp Request/Response bodies #4796

Are you sure you want to change the base?

feat(replay): Adding OkHttp Request/Response bodies #4796

Conversation

43jay commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📜 Description

TODOs

💡 Motivation and Context

💚 How did you test it?

Uh oh!

linear bot commented Oct 9, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

seer-by-sentry bot Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

romtsn Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

43jay Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

romtsn Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

43jay Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

43jay Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

43jay commented Oct 9, 2025 •

edited

Loading

romtsn Oct 30, 2025 •

edited

Loading

43jay Nov 4, 2025 •

edited

Loading

romtsn Oct 29, 2025 •

edited

Loading

43jay Nov 3, 2025 •

edited

Loading

43jay Nov 3, 2025 •

edited

Loading