Skip to content

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Sep 11, 2025

📜 Description

  • Add framesLock and guard addFrame/rotate with it.
  • Add firstFrameTimestamp that uses the lock to access the first frame
  • Use a frames snapshot in createVideoOf to avoid concurrent access while writers can write

💡 Motivation and Context

Closes #4632

💚 How did you test it?

Manually + automated

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Sep 11, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 371.31 ms 372.00 ms 0.69 ms
Size 1.58 MiB 2.10 MiB 532.92 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
85d7417 347.21 ms 394.35 ms 47.15 ms
674d437 355.28 ms 504.18 ms 148.90 ms
7314dbe 437.83 ms 505.64 ms 67.81 ms
3699cd5 423.60 ms 495.52 ms 71.92 ms
17a0955 372.53 ms 446.70 ms 74.17 ms
ee747ae 382.73 ms 435.41 ms 52.68 ms
ee747ae 405.43 ms 485.70 ms 80.28 ms
b750b96 421.25 ms 444.09 ms 22.84 ms
ee747ae 357.79 ms 421.84 ms 64.05 ms
ee747ae 386.94 ms 431.43 ms 44.49 ms

App size

Revision Plain With Sentry Diff
85d7417 1.58 MiB 2.10 MiB 533.44 KiB
674d437 1.58 MiB 2.10 MiB 530.94 KiB
7314dbe 1.58 MiB 2.10 MiB 533.45 KiB
3699cd5 1.58 MiB 2.10 MiB 533.45 KiB
17a0955 1.58 MiB 2.10 MiB 533.20 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
b750b96 1.58 MiB 2.10 MiB 533.20 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB

Previous results on branch: rz/fix/session-replay-cache-concurrency

Startup times

Revision Plain With Sentry Diff
05e3095 411.56 ms 492.72 ms 81.16 ms

App size

Revision Plain With Sentry Diff
05e3095 1.58 MiB 2.10 MiB 532.65 KiB

@romtsn romtsn enabled auto-merge (squash) September 15, 2025 14:59
@romtsn romtsn merged commit 9cd3c36 into main Sep 15, 2025
44 of 45 checks passed
@romtsn romtsn deleted the rz/fix/session-replay-cache-concurrency branch September 15, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReplayCache: Fatal Exception: java.util.NoSuchElementException
2 participants