-
-
Notifications
You must be signed in to change notification settings - Fork 460
Do not store No-Op scopes onto OpenTelemetry Context when wrapping #4631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
adinauer
merged 4 commits into
main
from
08-11-do_not_store_no-op_scopes_onto_opentelemetry_context_when_wrapping
Aug 12, 2025
Merged
Do not store No-Op scopes onto OpenTelemetry Context when wrapping #4631
adinauer
merged 4 commits into
main
from
08-11-do_not_store_no-op_scopes_onto_opentelemetry_context_when_wrapping
Aug 12, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adinauer
commented
Aug 11, 2025
...-opentelemetry-bootstrap/src/test/kotlin/io/sentry/opentelemetry/SentryContextWrapperTest.kt
Outdated
Show resolved
Hide resolved
Performance metrics 🚀
|
|
@sentry review |
|
cursor review |
🚨 Bugbot couldn't runSomething went wrong. Try again by commenting "Cursor review" or "bugbot run", or contact support (requestId: serverGenReqId_9f2447c3-65f0-416f-8c46-92bccde538c7). |
|
Cursor review |
…otlin/io/sentry/opentelemetry/SentryContextWrapperTest.kt
43264f8 to
4c84c2e
Compare
alexander-alderman-webb
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

📜 Description
In 8.18.0 we introduced a change that caused the root OTel scope to be wrapped by Sentry using
SentryContextWrapper. If the Sentry SDK hasn't been initialized yet, this would cause theContextto containNoOpScopesmeaning the SDK is broken for any code using that poisonedContext.💡 Motivation and Context
Fixes #4622
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps