chore(docs): fix javadoc link #4524
Closed
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaMoelans
requested review from
adinauer,
romtsn,
stefanosiano,
markushi and
lcian
as code owners
|
I'd rather us fix our gh-pages deployments because javadoc.io takes a while to sync the latest version and also does not include all modules |
|
@romtsn I just looked at the gh-pages branch and saw that we can point at specific modules (e.g. https://getsentry.github.io/sentry-java/sentry/) , so yeah since it is not fully empty, think using the existing pages is better than changing it to the javadocs site indeed ^ |
|
Superseded by #4525 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
like Roman mentioned below, fixing gh-pages is a better solution 😅 didn't notice we had something being deployed on there, but that it's just the modules overview not existing
Just happened to spot a dead link in the Readme pointing to https://getsentry.github.io/sentry-java/ , and saw on this issue that javadoc.io has javadocs for the latest release.
Not sure if we want to point at javadoc.io instead of our own github page, but having a dead link is not much better either :p
#skip-changelog