Skip to content

Update profile chunk rate limit and client report #4353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 24, 2025

Conversation

stefanosiano
Copy link
Member

📜 Description

update rate limiting and client reports for profile chunks from profile_chunk to profile_chunk_ui

💡 Motivation and Context

Rate limiting is different for UI and backend profiling, so they have different keys

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • sentry/src/main/java/io/sentry/transport/RateLimiter.java

@stefanosiano stefanosiano marked this pull request as ready for review April 23, 2025 14:31
Copy link
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • sentry/src/main/java/io/sentry/transport/RateLimiter.java

Copy link
Contributor

github-actions bot commented Apr 23, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 438.21 ms 500.31 ms 62.10 ms
Size 1.58 MiB 2.08 MiB 507.28 KiB

Previous results on branch: fix/update-profile-chunk-category

Startup times

Revision Plain With Sentry Diff
2415e79 456.06 ms 519.55 ms 63.49 ms

App size

Revision Plain With Sentry Diff
2415e79 1.58 MiB 2.08 MiB 507.28 KiB

Copy link
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • sentry/src/main/java/io/sentry/transport/RateLimiter.java

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stefanosiano stefanosiano merged commit 6df3ba5 into main Apr 24, 2025
39 checks passed
@stefanosiano stefanosiano deleted the fix/update-profile-chunk-category branch April 24, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants