Skip to content

Reactor module fixes #4160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Conversation

adinauer
Copy link
Member

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Reactor module fixes ([#4160](https://github.com/getsentry/sentry-java/pull/4160))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 2f59bff

Copy link
Member

@lcian lcian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you!

@lcian lcian merged commit 79bcd82 into lcian/ref/reactor-as-module Feb 11, 2025
30 of 32 checks passed
@lcian lcian deleted the feat/reactor-as-module-fixes branch February 11, 2025 13:59
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 385.98 ms 481.86 ms 95.88 ms
Size 1.58 MiB 2.21 MiB 640.28 KiB

Baseline results on branch: lcian/ref/reactor-as-module

Startup times

Revision Plain With Sentry Diff
4bbe412 423.04 ms 466.40 ms 43.36 ms

App size

Revision Plain With Sentry Diff
4bbe412 1.58 MiB 2.21 MiB 640.27 KiB

lcian added a commit that referenced this pull request Feb 17, 2025
* Refactor `ReactorUtils` into its own `sentry-reactor` module

* comment out failing tests

* add dependency to sentry-samples-spring-boot-webflux-jakarta

* fixes (#4160)

* update

* update

* update

* changelog

* update

* readme

* Update README.md

* Update CHANGELOG.md

---------

Co-authored-by: Alexander Dinauer <adinauer@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants