-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SR] Support multi-touch gestures #3473
Merged
romtsn
merged 5 commits into
rz/feat/session-replay
from
rz/feat/session-replay-multi-touch
Jun 22, 2024
Merged
[SR] Support multi-touch gestures #3473
romtsn
merged 5 commits into
rz/feat/session-replay
from
rz/feat/session-replay-multi-touch
Jun 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
b57c020 | 502.80 ms | 620.77 ms | 117.97 ms |
547b3f8 | 388.65 ms | 470.27 ms | 81.61 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
b57c020 | 1.70 MiB | 2.33 MiB | 641.35 KiB |
547b3f8 | 1.70 MiB | 2.33 MiB | 641.35 KiB |
Previous results on branch: rz/feat/session-replay-multi-touch
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
c2bfc47 | 399.31 ms | 449.98 ms | 50.67 ms |
7c81908 | 350.06 ms | 413.12 ms | 63.06 ms |
e30b072 | 408.04 ms | 478.44 ms | 70.40 ms |
126a38b | 379.50 ms | 453.27 ms | 73.77 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
c2bfc47 | 1.70 MiB | 2.33 MiB | 641.90 KiB |
7c81908 | 1.70 MiB | 2.33 MiB | 641.90 KiB |
e30b072 | 1.70 MiB | 2.33 MiB | 641.90 KiB |
126a38b | 1.70 MiB | 2.33 MiB | 641.58 KiB |
Base automatically changed from
rz/fix/session-replay-redaction
to
rz/feat/session-replay
June 18, 2024 13:44
brustolin
approved these changes
Jun 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
markushi
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one, LGTM!
sentry-android-replay/src/main/java/io/sentry/android/replay/capture/BaseCaptureStrategy.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog
📜 Description
pointerId to array[position]
There are also 2 irrelevant to this PR changes, but I've jsut made them as I discovered to not forget about them later:
DefaultReplayBreadcrumbConverter
)SessionCaptureStrategy
)💡 Motivation and Context
Part of getsentry/sentry#70065
Example replay: https://sentry-sdks.sentry.io/replays/9aedc6321c9949e09d649d7757cd5b32/?project=5428559&query=&referrer=%2Freplays%2F%3AreplaySlug%2F&statsPeriod=1h&yAxis=count%28%29&t=0