Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR] Support multi-touch gestures #3473

Merged
merged 5 commits into from
Jun 22, 2024

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Jun 11, 2024

#skip-changelog

📜 Description

  • Support multi-touch gestures by keeping track of pointerIds via a map of pointerId to array[position]

There are also 2 irrelevant to this PR changes, but I've jsut made them as I discovered to not forget about them later:

  • Debounce connectivity breadcrumbs when the state hasn't changed (DefaultReplayBreadcrumbConverter)
  • Fix crash in case segmentTimestamp is not available (discovered in one of alpha customer's issues). In case it's not available we simply set the duration to 0 meaning that we will not capture the segment (SessionCaptureStrategy)

💡 Motivation and Context

Part of getsentry/sentry#70065

Example replay: https://sentry-sdks.sentry.io/replays/9aedc6321c9949e09d649d7757cd5b32/?project=5428559&query=&referrer=%2Freplays%2F%3AreplaySlug%2F&statsPeriod=1h&yAxis=count%28%29&t=0

Copy link
Contributor

github-actions bot commented Jun 11, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 362.72 ms 439.82 ms 77.10 ms
Size 1.70 MiB 2.33 MiB 641.89 KiB

Baseline results on branch: rz/feat/session-replay

Startup times

Revision Plain With Sentry Diff
b57c020 502.80 ms 620.77 ms 117.97 ms
547b3f8 388.65 ms 470.27 ms 81.61 ms

App size

Revision Plain With Sentry Diff
b57c020 1.70 MiB 2.33 MiB 641.35 KiB
547b3f8 1.70 MiB 2.33 MiB 641.35 KiB

Previous results on branch: rz/feat/session-replay-multi-touch

Startup times

Revision Plain With Sentry Diff
c2bfc47 399.31 ms 449.98 ms 50.67 ms
7c81908 350.06 ms 413.12 ms 63.06 ms
e30b072 408.04 ms 478.44 ms 70.40 ms
126a38b 379.50 ms 453.27 ms 73.77 ms

App size

Revision Plain With Sentry Diff
c2bfc47 1.70 MiB 2.33 MiB 641.90 KiB
7c81908 1.70 MiB 2.33 MiB 641.90 KiB
e30b072 1.70 MiB 2.33 MiB 641.90 KiB
126a38b 1.70 MiB 2.33 MiB 641.58 KiB

Base automatically changed from rz/fix/session-replay-redaction to rz/feat/session-replay June 18, 2024 13:44
@romtsn romtsn marked this pull request as ready for review June 18, 2024 21:57
Copy link

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, LGTM!

@romtsn romtsn merged commit cfc52d9 into rz/feat/session-replay Jun 22, 2024
19 of 20 checks passed
@romtsn romtsn deleted the rz/feat/session-replay-multi-touch branch June 22, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants