Test Android Breakpad Minidumps #1256
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1256 +/- ##
=========================================
Coverage 74.91% 74.91%
Complexity 1743 1743
=========================================
Files 183 183
Lines 6118 6118
Branches 609 609
=========================================
Hits 4583 4583
Misses 1256 1256
Partials 279 279 Continue to review full report at Codecov.
|
| // event and minidump need to be within the same envelope, so right now we are not enriching | ||
| // the event as a hacky solution, but event is gonna ne symbolicated using the minidump | ||
| hub.captureEnvelope(envelope, hint); | ||
| if (!waitFlush(hint)) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
we'd need to special case this if we go ahead with mini dumps, as we need to enrich the event but still sending all the left items within the same envelope
|
@Swatinem can we close this? |
|
@marandaneto lets keep this open for now, I would love to be able to play around more with breakpad on Android. Half of the experiment is adding support for passing through the special minidump attachment, I guess that would be interesting to do independently in a separate PR? |
attachmentType is now preserved but event and minidump would still be sent separated which is still a problem as it's not going to symbolicated. |
|
@Swatinem can we close this now? looks stale for a while |
|
I don’t think it hurts keeping the branch around. And it might also be a good idea to properly implement this. I know of one customer who wanted to have proper minidumps on Android, with all the different threads in it. |
let's keep the branch around but close the PR since it's just noise in the ever-growing list of PRs, we can always reopen later |
📜 Description
Just for testing android breakpad
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
🔮 Next steps