Remove duplicated Novoda plugin config. #1007
Conversation
maciejwalkowiak
requested review from
bruno-garcia and
marandaneto
as code owners
build.gradle.kts
Outdated
| publishVersion = project.version.toString() | ||
| desc = Config.Sentry.description | ||
| website = Config.Sentry.website | ||
| repoName = Config.Sentry.javaRepoName |
There was a problem hiding this comment.
Ok now I see the difference between Java and Android repo.
There was a problem hiding this comment.
What is the difference? We moved from https://github.com/getsentry/sentry-android into this one, isnt' it all the same now?
There was a problem hiding this comment.
Oh, is this a bintray repo?
There was a problem hiding this comment.
if so could it be named bintrayRepo please?
There was a problem hiding this comment.
no, java packages go under sentry-java, android packages go sentry-android and its not possible to change, we'd lose jcenter sync cus its a bintray limitation
There was a problem hiding this comment.
yeah I realize that on the second comment.
I suggested rename the variable. repoName is very ambiguous
|
@maciejwalkowiak I found problems doing something similar but on a few older Gradle's version , the kotlin build scripts were a bit limited yet, I think it should be fine now. |
|
Thanks @marandaneto. The output of |
build.gradle.kts
Outdated
| publishVersion = project.version.toString() | ||
| desc = Config.Sentry.description | ||
| website = Config.Sentry.website | ||
| repoName = if (project.name.contains("android")) Config.Sentry.androidRepoName else Config.Sentry.javaRepoName |
There was a problem hiding this comment.
The suggestion is this, though PR is good to merge:
| repoName = if (project.name.contains("android")) Config.Sentry.androidRepoName else Config.Sentry.javaRepoName | |
| repoName = if (project.name.contains("android")) Config.Sentry.androidBintrayRepoName else Config.Sentry.javaBintrayRepoName |
There was a problem hiding this comment.
it makes easier to read but also verbose, its setting in the bintray plugin repoName field so it's kinda implicit that its bintray's repo name, I'm fine with this change though.
If you had a doubt about the var you are probably right, I wrote this part myself :D
Codecov Report
@@ Coverage Diff @@
## main #1007 +/- ##
=======================================
Coverage ? 71.61%
Complexity ? 1299
=======================================
Files ? 134
Lines ? 4731
Branches ? 490
=======================================
Hits ? 3388
Misses ? 1087
Partials ? 256
Continue to review full report at Codecov.
|
📢 Type of change
📜 Description
Remove duplicated Novoda plugin config.
Configuration has been moved from each module to parent
build.gradle.ktsintosubprojectssection.💡 Motivation and Context
getsentry/sentry-android#537 (comment)
💚 How did you test it?
Build distribution packages
distZipand compared with distributions created before the change.📝 Checklist
🔮 Next steps
@marandaneto since I am not very fluent in Gradle I would appreciate your deeper review here.