Skip to content

Improve Oban error reporting #872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2025
Merged

Conversation

whatyouhide
Copy link
Collaborator

  • We don't report {:discard or {:cancel return values
  • We unwrap Oban.PerformErrors if the return value is an exception
  • Moar tests

@whatyouhide whatyouhide merged commit 759ed98 into master Mar 5, 2025
3 of 4 checks passed
@whatyouhide whatyouhide deleted the al/better-oban-fingerprinting branch March 5, 2025 16:31
@mbaleczny
Copy link
Contributor

Hi @whatyouhide 👋 FYI It looks like this PR changes makes this part of the documentation invalid. Is there any other easy way to avoid reporting handled errors {:error, reason}, {:cancel, reason}, {:discard, reason}?

@whatyouhide
Copy link
Collaborator Author

@mbaleczny wait, I am not sure what it is you want to do. Start reporting those again, or stop reporting them?

@mbaleczny
Copy link
Contributor

mbaleczny commented May 7, 2025

@whatyouhide I want to stop reporting them. But I want the crashed and timed out oban jobs being reported. That used to work when errors were wrapped with Oban.PerformError.

@whatyouhide
Copy link
Collaborator Author

That's how things should be working now: Only reports crashes, but not :cancels and :discards. I'll need a bit more info about this as this is the first report of this not working as expected. Could you please open up an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants