Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Logger.add_backend/1 #472

Merged
merged 2 commits into from
Apr 8, 2021
Merged

Use Logger.add_backend/1 #472

merged 2 commits into from
Apr 8, 2021

Conversation

josevalim
Copy link
Contributor

Configuring the backend on config/config.exs may be too early
and cause issues if trying to loading logger config before Sentry
is compiled.

Or it can be an issue in umbrella projects when only some of them
depend on Sentry.

Configuring the backend on config/config.exs may be too early
and cause issues if trying to loading logger config before Sentry
is compiled.

Or it can be an issue in umbrella projects when only some of them
depend on Sentry.
@josevalim
Copy link
Contributor Author

Note the previous snippet also wouldn't work for releases. :)

@thbar
Copy link

thbar commented Apr 8, 2021

it can be an issue in umbrella projects when only some of them
depend on Sentry.

Thanks @josevalim - it is one of the pain points I've had in the umbrella app I'm managing, this will help greatly.

@mitchellhenke
Copy link
Contributor

@josevalim Thank you so much!! 💖

@mitchellhenke mitchellhenke merged commit 17ffa85 into getsentry:master Apr 8, 2021
@morgz
Copy link

morgz commented Oct 19, 2021

Could you also update your getting started to refer to this way of implementing the logger?

@josevalim
Copy link
Contributor Author

@morgz if we mention the "old way" on the website, then please send a PR, but the getting started per se does not cover additional logger backends. This change is mentioned in the Logger docs though.

@josevalim josevalim deleted the patch-1 branch October 19, 2021 12:29
@morgz
Copy link

morgz commented Oct 19, 2021

@morgz if we mention the "old way" on the website, then please send a PR, but the getting started per se does not cover additional logger backends. This change is mentioned in the Logger docs though.

Here you go - Can I suggest you add an "Edit on Github" button to your documentation. Before commenting here I looked for that and without it, I had to go hunting through your repos. See example on the Apollo Docs

@josevalim
Copy link
Contributor Author

Oh, I am so sorry, I thought you were referring to Elixir's getting started guide. My bad, thanks for the PR though!

@mitchellhenke
Copy link
Contributor

@morgz thanks for updating the docs!

AbhiPrasad added a commit to getsentry/sentry-docs that referenced this pull request Nov 12, 2021
Update as per getsentry/sentry-elixir#472. 

Co-authored-by: Daniel Morgan <danmorgz@googlemail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants