-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Logger.add_backend/1 #472
Conversation
Configuring the backend on config/config.exs may be too early and cause issues if trying to loading logger config before Sentry is compiled. Or it can be an issue in umbrella projects when only some of them depend on Sentry.
Note the previous snippet also wouldn't work for releases. :) |
Thanks @josevalim - it is one of the pain points I've had in the umbrella app I'm managing, this will help greatly. |
@josevalim Thank you so much!! 💖 |
Could you also update your getting started to refer to this way of implementing the logger? |
@morgz if we mention the "old way" on the website, then please send a PR, but the getting started per se does not cover additional logger backends. This change is mentioned in the Logger docs though. |
Here you go - Can I suggest you add an "Edit on Github" button to your documentation. Before commenting here I looked for that and without it, I had to go hunting through your repos. See example on the Apollo Docs |
Oh, I am so sorry, I thought you were referring to Elixir's getting started guide. My bad, thanks for the PR though! |
@morgz thanks for updating the docs! |
Update as per getsentry/sentry-elixir#472. Co-authored-by: Daniel Morgan <danmorgz@googlemail.com>
Configuring the backend on config/config.exs may be too early
and cause issues if trying to loading logger config before Sentry
is compiled.
Or it can be an issue in umbrella projects when only some of them
depend on Sentry.