Repository navigation
fix: events from the logging integrations list the integration's package in sdk.packages - #5693
Merged
Merged
Conversation
…ents it captures The Serilog, NLog, log4net and Microsoft.Extensions.Logging integrations stopped adding their package when they stopped setting sdk.name. Add it back to each event they create, leaving sdk.name to the integration that initialized the SDK. Closes #5649 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## version7 #5693 +/- ##
============================================
+ Coverage 74.65% 75.18% +0.53%
============================================
Files 505 520 +15
Lines 18372 18910 +538
Branches 3535 3669 +134
============================================
+ Hits 13715 14217 +502
- Misses 3796 3830 +34
- Partials 861 863 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ric-oliv
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On
version7, events captured by the Serilog sink, the NLog target, the log4net appender andSentryLoggerno longer listed the integration's package insdk.packages. When #5573, #5585, #5592 and #5595 stopped the logging integrations from settingsdk.name, they also removed theAddPackagecalls. This change adds the package back to each event those integrations create.sdk.namedoesn't change, so it still identifies the integration that initialized the SDK.In 6.x, the Microsoft.Extensions.Logging package was added to a scope that
SentryLoggerProviderpushed, so it showed up on every event. NowSentryLoggeradds it only to the events it creates, the same as the other three integrations.Each integration builds its package once, using a small internal
GetNuGetPackage()helper in core.Notes
#skip-changelog.SdkVersion(IgnoreMembersWithType<SdkVersion>()), so the new tests checksdk.packagesdirectly.Closes #5649
#skip-changelog
🤖 Generated with Claude Code