Repository navigation
Conversation
1 of 3 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## danf/quartz-5505-rebased #5668 +/- ##
===========================================================
Coverage ? 75.50%
===========================================================
Files ? 525
Lines ? 19279
Branches ? 3775
===========================================================
Hits ? 14557
Misses ? 3842
Partials ? 880 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
wedamija
force-pushed
the
danf/quartz-crons
branch
from
October 6, 2026 02:03
6128fc0 to
91bd0d1
Compare
Compiles the Sentry.Quartz core (schedule conversion, slugs, options and check-ins) against Quartz 3.6+ and drives it from an IJobListener, since Quartz 3 has no job middleware. Logs an error at startup when Quartz 4 is loaded, where the listener's Task methods would never be called. Co-Authored-By: Claude <noreply@anthropic.com>
Quartz 3 needs exactly one '?' day field, so only that form is converted. ConfigureMonitorOptions gets the listener's IJobExecutionContext, and the final check-in reuses the ID created for the in-progress one. Co-Authored-By: Claude <noreply@anthropic.com>
wedamija
force-pushed
the
danf/quartz-crons
branch
from
October 8, 2026 21:31
d304dc1 to
37ac6e2
Compare
wedamija
changed the base branch from
danf/quartz4-crons
to
danf/quartz-5505-rebased
October 8, 2026 21:32
Co-Authored-By: Claude <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stacked on #5505 (base branch
danf/quartz-5505-rebasedis a copy of #5505's branch).Adds
Sentry.Quartz3, the Quartz.NET 3.x add-on toSentry.Quartz(#5505). It compiles the same core files (schedule conversion, slugs, options, check-ins) against Quartz[3.6.0,4.0.0)for net8.0, net9.0, net10.0 and net462, and runs them from anIJobListener, since Quartz 3 has no job middleware.Check-ins and monitor configs work as in
Sentry.Quartz: only jobs with[SentryCronMonitorSlug]are monitored, and their trigger's schedule is sent unlessSendMonitorConfigis off. A listener can't wrap the job, so there is no per-job scope or exception capture.Quartz 4 changed
IJobListenerto returnValueTaskwith default implementations, so this listener would load there but never be called. It logs an error pointing toSentry.Quartzinstead.A release-registry entry is needed before the first release.
Motivation
Quartz 4 only targets net10.0, so apps on .NET Framework or older .NET stay on Quartz 3. They need the same check-ins, and sharing the core keeps the extra code to the listener.
Testing
The core tests from
Sentry.Quartz.Testsrun against Quartz 3.6 on net8.0, net9.0 and net10.0 (and net48 on Windows), plus listener tests and a real-scheduler test. API approval files added.Docs: getsentry/sentry-docs#19790