Skip to content

chore: Refactor SentryAttributes into a separate class - #4936

Merged
jamescrosswell merged 11 commits into
mainfrom
sentry-attributes
May 13, 2026
Merged

jamescrosswell merged 11 commits into
mainfrom
sentry-attributes

Apply review suggestions: doc wording and test assertion consistency

7699aaa
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 13, 2026 in 1s

74.12% (+0.03%) compared to 0b59060

View this Pull Request on Codecov

74.12% (+0.03%) compared to 0b59060

Details

Codecov Report

❌ Patch coverage is 80.95238% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.12%. Comparing base (0b59060) to head (7699aaa).
⚠️ Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
src/Sentry/Protocol/SentryAttributes.cs 75.55% 10 Missing and 1 partial ⚠️
src/Sentry/SentryMetric.Factory.cs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4936      +/-   ##
==========================================
+ Coverage   74.08%   74.12%   +0.03%     
==========================================
  Files         506      508       +2     
  Lines       18247    18282      +35     
  Branches     3564     3574      +10     
==========================================
+ Hits        13519    13551      +32     
- Misses       3858     3861       +3     
  Partials      870      870              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.