-
-
Notifications
You must be signed in to change notification settings - Fork 229
fix: Allow Sentry failures when SENTRY_ALLOW_FAILURE is set in the Sentry CLI #4852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: Allow Sentry failures when SENTRY_ALLOW_FAILURE is set in the Sentry CLI #4852
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 4 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4852 +/- ##
=======================================
Coverage 73.80% 73.80%
=======================================
Files 483 483
Lines 17551 17551
Branches 3461 3461
=======================================
+ Hits 12953 12954 +1
+ Misses 3746 3745 -1
Partials 852 852 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jamescrosswell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @DanielMcAssey !
I had a quick look at it. From what I can tell, I think the new property would need to be used in a couple of extra places for this to have the desired effect... but maybe I'm not seeing something obvious.
|
During testing, I was not getting build failures, until it hit the propose version command. Its because everywhere else has |
Added a section for fixes and documented a new feature and dependency update.
This PR adds support for SENTRY_ALLOW_FAILURE.
This fixes #4849