Skip to content

Conversation

@DanielMcAssey
Copy link

@DanielMcAssey DanielMcAssey commented Jan 20, 2026

This PR adds support for SENTRY_ALLOW_FAILURE.
This fixes #4849

## Unreleased

### Fixes

- Allow Sentry failures when SENTRY_ALLOW_FAILURE is set (#4852)

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 4 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@codecov
Copy link

codecov bot commented Jan 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.80%. Comparing base (ad83c58) to head (8e67b15).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4852   +/-   ##
=======================================
  Coverage   73.80%   73.80%           
=======================================
  Files         483      483           
  Lines       17551    17551           
  Branches     3461     3461           
=======================================
+ Hits        12953    12954    +1     
+ Misses       3746     3745    -1     
  Partials      852      852           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@jamescrosswell jamescrosswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @DanielMcAssey !

I had a quick look at it. From what I can tell, I think the new property would need to be used in a couple of extra places for this to have the desired effect... but maybe I'm not seeing something obvious.

@DanielMcAssey
Copy link
Author

During testing, I was not getting build failures, until it hit the propose version command. Its because everywhere else has IgnoreExitCode="true" ContinueOnError="WarnAndContinue"

@jamescrosswell jamescrosswell changed the title Add support for SENTRY_ALLOW_FAILURE fix: Allow Sentry failures when SENTRY_ALLOW_FAILURE is set in the Sentry CLI Jan 22, 2026
Added a section for fixes and documented a new feature and dependency update.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SENTRY_ALLOW_FAILURE=true still fails the build

2 participants