-
-
Notifications
You must be signed in to change notification settings - Fork 220
WIP: Unsampled Transactions to reduce memory pressure #3972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Unsampled Transactions to reduce memory pressure ([#3972](https://github.com/getsentry/sentry-dotnet/pull/3972)) If none of the above apply, you can opt out of this check by adding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One concern I have is; Does this affect our ability to create and propagate trace ids downstream? or to continue a trace (on aspnetcore) if a transaction wasn't sampled?
I don't think so no... I thought about that when creating the UnsampledTransaction class (making sure trace propagation still works). Some further testing could be done to double/triple check this. I guess it's lots of questions like this that make me a bit nervous - it's the sort of change that really requires thorough testing before rolling it out. In an ideal world, that would all be covered by unit tests, but I'm not sure that's the case. |
We have nugettrends.com and symbol collector to test it out |
We should really ship this btw |
I'll bump the priority and pick it back up again... probably/hopefully just needs to be updated from main 🤞🏻 |
WIP... really needs to be done after #3951 gets merged as it's fiddling with the same sections of code (and needs to take into account the sample_rand etc. as well).
Not sure if this is worth finishing since we eventually plan to get rid of transactions entirely.