-
-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Minimal Blazor support #3386
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the idea of this entry point to start the project!!
src/Sentry.AspNetCore.Blazor/WebAssemblyHostBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
…y-dotnet into feat/blazor-base
src/Sentry.AspNetCore.Blazor.WebAssembly/WebAssemblyHostBuilderExtensions.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bitsandfoxes it looks like the even that comes through to Sentry is being marked as Handled even though the exception is not caught... but I think we have a separate issue to track this as it's an issue with our logging integration rather than our blazor wasm integration:
The other thing that is a bit confusing is that the Nav menu is titled "Throw, Catch and Capture" even though the code is just doing a throw.
I had to look at the code to work out that this was a nav menu actually... initially I though that clicking on that link would throw, catch and capture and exception (one with handled=true
) and that clicking on the button would throw and unhandled exception... demonstrating that the integration will catch both kinds of exceptions.
So overall, the integration itself looks great... but the Sample project is quite confusing. I think it's worth tweaking the UI in the sample project to make this less confusing.
Resolves #2021
Docs: getsentry/sentry-docs#10344