Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async void helper #3379

Merged
merged 7 commits into from
May 24, 2024
Merged

Async void helper #3379

merged 7 commits into from
May 24, 2024

Conversation

jamescrosswell
Copy link
Collaborator

Resolves #3359

@jamescrosswell jamescrosswell marked this pull request as ready for review May 22, 2024 09:55
Copy link
Contributor

@bitsandfoxes bitsandfoxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's awesome!

@bitsandfoxes bitsandfoxes merged commit 28bd2a8 into main May 24, 2024
21 checks passed
@bitsandfoxes bitsandfoxes deleted the async-void-helper branch May 24, 2024 12:19
@bruno-garcia
Copy link
Member

This is a killer feature! Congtats!

I wonder if we have this on the docs anywhere already, or there's a changelog entry or a blog post to let the world know about it :)

@jamescrosswell
Copy link
Collaborator Author

I wonder if we have this on the docs anywhere already, or there's a changelog entry or a blog post to let the world know about it :)

It would definitely be good to have it in the docs. Although, it doesn't really fit neatly into the current doc structure.

  • Configuration
  • Usage
  • Unit Testing
  • Enriching Events
  • Data Management
  • Setup [various features]
  • Migration Guide
  • Legacy SDK
  • Troubleshooting

It's not really configuration and it's also not related to any of the other features. The best place I can think to put it is under Usage. That elevates it next to some pretty key characteristics of the SDK however...

I've created a pull request to add some docs under Usage and we can always tweak this if we find a better place to put it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SentrySdk.RunAsyncVoid helper method to Sentry SDK
3 participants