Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Hints now accept byte[] as attachment #3352

Merged
merged 4 commits into from
May 8, 2024
Merged

feat: Hints now accept byte[] as attachment #3352

merged 4 commits into from
May 8, 2024

Conversation

bitsandfoxes
Copy link
Contributor

Fixes #3350

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2024 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 3a47bb6

jamescrosswell
jamescrosswell approved these changes May 7, 2024
View reviewed changes
Copy link
Collaborator

@jamescrosswell jamescrosswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... just one small bit of redundant code to remove, I think.

src/Sentry/SentryHint.cs Outdated Show resolved Hide resolved
@bitsandfoxes bitsandfoxes merged commit f8e84bb into main May 8, 2024
20 checks passed
@bitsandfoxes bitsandfoxes deleted the fix/attachment-bytearray branch May 8, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamescrosswell jamescrosswell jamescrosswell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing AddAttachment from memory in SentryHint
2 participants
@bitsandfoxes @jamescrosswell