-
-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: vsnprintf usage on macOS #3079
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3079 +/- ##
==========================================
+ Coverage 76.43% 76.45% +0.01%
==========================================
Files 351 351
Lines 13259 13259
Branches 2644 2644
==========================================
+ Hits 10135 10137 +2
+ Misses 2447 2446 -1
+ Partials 677 676 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we get some context in the PR summary for what this change is about? Does it relate to an Issue? What was the problem and how does this solve it?
says it all in the PR title, really, but OK, I'll add the same to the description |
That's helpful. I wasn't aware that vsnprintf was windows only (I've never heard of it before) or that the code we had was copied from Unity. So the whole PR was just mysterious to me. |
It's not, but we have a windows-only variant defined in the class (IIRC it has different arguments), and since the code switched on linux vs rest of the world (which was just Windows in Unity), macOS was trying to use that windows variant too. |
vsnprintf
was used incorrectly on macOS (used the windows version) because this code was copied from sentry-unity where it didn't run on mac, only Windows and Linux.