Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Sanitize value in metrics #3065

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Conversation

bitsandfoxes
Copy link
Contributor

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we had tests we wouldn't have had this bug in prod, can u add a test?

@bitsandfoxes
Copy link
Contributor Author

if we had tests we wouldn't have had this bug in prod, can u add a test?

Of course!

@jamescrosswell
Copy link
Collaborator

if we had tests we wouldn't have had this bug in prod, can u add a test?

We probably need tests more generally for the metrics capability. We intentionally didn't do much testing just to put a POC together but I think we need to circle back to this:

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d3f2f7a) 76.42% compared to head (8d0c9d0) 75.39%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3065      +/-   ##
==========================================
- Coverage   76.42%   75.39%   -1.03%     
==========================================
  Files         351      351              
  Lines       13263    13259       -4     
  Branches     2646     2644       -2     
==========================================
- Hits        10136     9997     -139     
- Misses       2450     2588     +138     
+ Partials      677      674       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamescrosswell jamescrosswell merged commit c50cb36 into main Jan 24, 2024
20 checks passed
@jamescrosswell jamescrosswell deleted the fix/metrics-sanitize-value branch January 24, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send statsd data to Sentry
3 participants