-
-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: native crash reporting #2887
Conversation
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- native crash reporting ([#2887](https://github.com/getsentry/sentry-dotnet/pull/2887)) If none of the above apply, you can opt out of this check by adding |
d67e074
to
8d3a2e9
Compare
005fc4b
to
2e51a9f
Compare
Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
2e51a9f
to
3342217
Compare
This is a problem on a Mac where the OS asks the user to give permission if the file is on Documents and others. It's a problem on Unity today btw ^ so we could align the solution here ALso a problem the fact we don't have paths by default. And the .NET SDK doesn't support having more than 1 instance of the app running at the same time (afaik not fixed) as worker transports would race to pick work off of the directory |
// You can set it in the SENTRY_DSN environment variable, or you can set it in code here. | ||
// options.Dsn = "... Your DSN ..."; | ||
|
||
// When debug is enabled, the Sentry client will emit detailed debugging information to the console. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Today setting a path (in the .NET layer) is the way to opt-in to offline caching. Are we changing that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Native backend uses offline caching to store the error at the time of the crash and only sends it later on the second app run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So is this also really an issue with SentryNative?
what do we want to do about the cache directory path? Defaults to the current working directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I get your question right, @jamescrosswell, then yes, this is only an issue with native crashes that are captured by sentry-native
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Today setting a path (in the .NET layer) is the way to opt-in to offline caching. Are we changing that?
We might document that, today we only say: Only disk access happen if u set a path here
samples/Sentry.Samples.Console.Native/Sentry.Samples.Console.Native.csproj
Show resolved
Hide resolved
Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
Closes #2770
TODO:
Sample event: https://sentry-sdks.sentry.io/issues/4677655767/events/025a40ef472d40b2fa0c3011bf3c68bf/
Sample log output (second run)