Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upload Android native symbols #2876

Merged
merged 7 commits into from
Nov 21, 2023
Merged

fix: upload Android native symbols #2876

merged 7 commits into from
Nov 21, 2023

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Nov 21, 2023

fixes #2860

Sample event symbolicated after the upload hasa been fixed: https://sentry-sdks.sentry.io/issues/4654919326/events/6e0ef2059d4045e03f6549ef6b34a310/

@vaind vaind changed the title fix: upload elf symbols fix: upload Android native symbols Nov 21, 2023
@vaind vaind marked this pull request as ready for review November 21, 2023 17:11
Copy link
Contributor

@bitsandfoxes bitsandfoxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks!

@vaind vaind merged commit c32be36 into feat/4.0.0 Nov 21, 2023
17 checks passed
@vaind vaind deleted the fix/android-elfs branch November 21, 2023 19:00
@@ -2,8 +2,14 @@

## Unreleased - 4.x

### API breaking Changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically this reverted the breakage, we can fix the final changelog before GA

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah since we had separated out the changes into -beta.1 etc. it was hard to know what to do... I didn't want to remove the breakage from the earlier alpha release as that would be misleading. But yeah, we can consolidate it all when we GA. 👍🏻

@bruno-garcia
Copy link
Member

Thanks for fixing this!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants