Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made Sentry.Values<T> internal #2771

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Made Sentry.Values<T> internal #2771

merged 2 commits into from
Oct 31, 2023

Conversation

jamescrosswell
Copy link
Collaborator

@jamescrosswell jamescrosswell commented Oct 31, 2023

Resolves #2665

Sentry.Values is only used internally. Publicly this is exposed in two places and in both cases as IEnumerable<T>:

internal SentryValues<SentryException>? SentryExceptionValues { get; set; }
/// <summary>
/// The Sentry Exception interface.
/// </summary>
public IEnumerable<SentryException>? SentryExceptions
{
get => SentryExceptionValues?.Values ?? Enumerable.Empty<SentryException>();
set => SentryExceptionValues = value != null ? new SentryValues<SentryException>(value) : null;
}
private SentryValues<SentryThread>? SentryThreadValues { get; set; }
/// <summary>
/// The Sentry Thread interface.
/// </summary>
/// <see href="https://develop.sentry.dev/sdk/event-payloads/threads/"/>
public IEnumerable<SentryThread>? SentryThreads
{
get => SentryThreadValues?.Values ?? Enumerable.Empty<SentryThread>();
set => SentryThreadValues = value != null ? new SentryValues<SentryThread>(value) : null;
}

@jamescrosswell jamescrosswell self-assigned this Oct 31, 2023
@jamescrosswell jamescrosswell changed the title Made Sentry.Values<T> private Made Sentry.Values<T> internal Oct 31, 2023
@jamescrosswell jamescrosswell marked this pull request as ready for review October 31, 2023 07:03
@github-actions
Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Made Sentry.Values<T> internal ([#2771](https://github.com/getsentry/sentry-dotnet/pull/2771))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 271f03c

@vaind vaind merged commit d691018 into feat/4.0.0 Oct 31, 2023
15 of 18 checks passed
@vaind vaind deleted the private-values branch October 31, 2023 12:04
@vaind
Copy link
Collaborator

vaind commented Oct 31, 2023

Danger was complaining because the changelog entry was missing a # before the number. See a448ab3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider removing SentryValues (or making this internal at least)
2 participants