Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: align StackFrame's properties #2691

Merged
merged 2 commits into from
Oct 3, 2023

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Oct 3, 2023

Normalizes types on address-related properties of the StackFrame protocol class.

This is a follow up to the deprecation in #2689

@vaind vaind force-pushed the chore/cleanup-stackframe-attributes-v4 branch from 9eb5ef6 to 41f900c Compare October 3, 2023 12:38
@vaind vaind force-pushed the chore/cleanup-stackframe-attributes-v4 branch from 41f900c to 5c89c0f Compare October 3, 2023 13:12
Copy link
Contributor

@bitsandfoxes bitsandfoxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LVGTM!

@vaind vaind merged commit b28cc31 into feat/4.0.0 Oct 3, 2023
5 of 6 checks passed
@vaind vaind deleted the chore/cleanup-stackframe-attributes-v4 branch October 3, 2023 16:22
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- align StackFrame's properties ([#2691](https://github.com/getsentry/sentry-dotnet/pull/2691))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against c55e0fe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants