Fix EnableTracing
option conflict with TracesSampleRate
#2368
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2366 by having
TracesSampleRate
andEnableTracing
properties have simple get/set implementations (except for some existing validation). This issue was mainly seen during configuration binding in ASP.NET Core applications, and then - only in the case whereEnableTracing
was settrue
andTracesSampleRate
was unset.Unfortunately, the only way to implement the correct fix was to make
TracesSampleRate
a nullabledouble?
. Previously, it was a non-nullabledouble
. (The default value is nownull
instead of0.0
.) Normally I'd consider that to be a breaking change that could not be done without a major version bump. But in this case, it's unlikely to affect anyone, because this property is typical set, but never retrieved externally.There are no behavioral changes. Both values work as they were originally intended.
I also improved the xmldocs, and fixed the exception type thrown when an invalid sample rate is set. (
ArgumentOutOfRangeException
, is more appropriate thanInvalidOperationException
for that).