Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Session breadcrumbs were added in #1263 (released in 3.11.0).
Unfortunately, this creates some confusion such as seen in #2046.
AutoSessionTracking = true
missed the start-of-session breadcrumb due to a bug (the hub it added the breadcrumb to is still disabled at that time).app.lifecycle
- which is incorrect. The lifetime of the session does not necessarily correlate to the lifetime of the application. If app lifecycle breadcrumbs are desired, they should be added directly with the application events - not tied to Sentry sessions.exited
session update whenAutoSessionTracking=true
. The only benefit of adding that would be to enable session duration tracking, but that was removed from Sentry recently. See Release Health: Retiring Session Duration - Your Feedback Needed sentry#42716 (comment)This PR removes session breadcrumbs. It does not change the behavior of sessions themselves.
It also adds some more diagnostic logging, and sets an appropriate level for existing logging messages.
(There's some minor code cleanup in here as well.)
Closes #2046