Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove session breadcrumbs #2333

Merged
merged 5 commits into from
Apr 27, 2023
Merged

Remove session breadcrumbs #2333

merged 5 commits into from
Apr 27, 2023

Conversation

mattjohnsonpint
Copy link
Contributor

@mattjohnsonpint mattjohnsonpint commented Apr 26, 2023

Session breadcrumbs were added in #1263 (released in 3.11.0).

Unfortunately, this creates some confusion such as seen in #2046.

  • Ending a session typically occurs after an event would be captured, so an end-of-session breadcrumb is usually absent.
  • Starting a session while one was already active would create an end-of-session breadcrumb followed by a new start-of-session breadcrumb, which often is confusing because they look out-of-sequence.
  • AutoSessionTracking = true missed the start-of-session breadcrumb due to a bug (the hub it added the breadcrumb to is still disabled at that time).
  • Pausing/Resuming Sentry sessions added breadcrumbs correctly, but they're still categorized as app.lifecycle - which is incorrect. The lifetime of the session does not necessarily correlate to the lifetime of the application. If app lifecycle breadcrumbs are desired, they should be added directly with the application events - not tied to Sentry sessions.
  • We currently don't send an exited session update when AutoSessionTracking=true. The only benefit of adding that would be to enable session duration tracking, but that was removed from Sentry recently. See Release Health: Retiring Session Duration - Your Feedback Needed sentry#42716 (comment)

This PR removes session breadcrumbs. It does not change the behavior of sessions themselves.

It also adds some more diagnostic logging, and sets an appropriate level for existing logging messages.

(There's some minor code cleanup in here as well.)

Closes #2046

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breadcrumbs added inconsistently for start/end of session
2 participants