Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Sentry.Android.AssemblyReader as a separate nuget package #2127

Merged
merged 13 commits into from
Jan 27, 2023

Conversation

mattjohnsonpint
Copy link
Contributor

This updates the AndroidAssemblyReader and related classes to be published in a separate nuget package. That allow us to consume it both from Sentry for .NET Android targets, and from Sentry.Xamarain, without affecting other targets. That will fix #2126, and allow us to get debug information in Xamarin apps, which will address getsentry/sentry-xamarin#134.

Also did some cleanup in here around global usings that came up while splitting it out, and improved the build process by replacing the update-test-apks.ps1 script with some MSBuild tasks.

@vaind
Copy link
Collaborator

vaind commented Jan 26, 2023

I've just realized... any way to make this work for Unity as well, while changing things up?

@mattjohnsonpint
Copy link
Contributor Author

I've just realized... any way to make this work for Unity as well, while changing things up?

I think it will just work. 🤞 We can try it in Unity after its published and make changes if Unity packages things differently.

@mattjohnsonpint mattjohnsonpint merged commit 4ee96ee into main Jan 27, 2023
@mattjohnsonpint mattjohnsonpint deleted the split-assembly-reader branch January 27, 2023 02:43
@mattjohnsonpint
Copy link
Contributor Author

I've just realized... any way to make this work for Unity as well, while changing things up?

I think it will just work. 🤞 We can try it in Unity after its published and make changes if Unity packages things differently.

@vaind - Looks like we would also need to adjust the path being searched in the APK, but shouldn't be too difficult I think.

getsentry/sentry-unity#1167

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AndroidAssemblyReader not available to Xamarin apps
3 participants