Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cli integration on Windows #2123

Merged
merged 2 commits into from
Jan 24, 2023
Merged

Fix cli integration on Windows #2123

merged 2 commits into from
Jan 24, 2023

Conversation

mattjohnsonpint
Copy link
Contributor

  • Needed to add .exe on the cli commands for Windows to pass Exists checks
  • Needed to use double quotes encoded as " instead of single quotes, when wrapping commands, paths, or arguments

@mattjohnsonpint mattjohnsonpint merged commit 9747a78 into main Jan 24, 2023
@mattjohnsonpint mattjohnsonpint deleted the fix-cli-windows branch January 24, 2023 03:16
@mattjohnsonpint mattjohnsonpint mentioned this pull request Jan 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruno-garcia bruno-garcia bruno-garcia approved these changes

@bitsandfoxes bitsandfoxes Awaiting requested review from bitsandfoxes bitsandfoxes is a code owner

@vaind vaind Awaiting requested review from vaind

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattjohnsonpint @bruno-garcia