Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update unobserved task exception integration #2034

Merged
merged 7 commits into from
Nov 9, 2022

Conversation

mattjohnsonpint
Copy link
Contributor

We had a few extraneous null checks in the TaskUnobservedTaskExceptionIntegration.

Also, we have been calling this TaskUnobservedTaskExceptionIntegration with the word Task twice. The exception raised is called UnobservedTaskException, so the leading word Task is redundant. Renaming all usage to UnobservedTaskExceptionIntegration.

This rename makes one public change. The DisableTaskUnobservedTaskExceptionCapture extension method is now obsolete in favor of DisableUnobservedTaskExceptionCapture.

Copy link
Contributor

@bitsandfoxes bitsandfoxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a nice little cleanup!

@mattjohnsonpint mattjohnsonpint merged commit 2df7d07 into main Nov 9, 2022
@mattjohnsonpint mattjohnsonpint deleted the update-unobservedtaskexcetpion-integration branch November 9, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants