Update unobserved task exception integration #2034
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a few extraneous null checks in the
TaskUnobservedTaskExceptionIntegration
._hub
variable will never be null withinHandle
, because that can only occur after registering the integration.Also, we have been calling this
TaskUnobservedTaskExceptionIntegration
with the wordTask
twice. The exception raised is calledUnobservedTaskException
, so the leading wordTask
is redundant. Renaming all usage toUnobservedTaskExceptionIntegration
.This rename makes one public change. The
DisableTaskUnobservedTaskExceptionCapture
extension method is now obsolete in favor ofDisableUnobservedTaskExceptionCapture
.