-
-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support more types for message template tags in SentryLogger #1945
Support more types for message template tags in SentryLogger #1945
Conversation
Implements #1944 if desired |
@babyjohn42 thanks. this will be included in the next release |
I added a changelog entry. Looks good otherwise. Thanks! |
@mattjohnsonpint lol. u just beat me t it |
@mattjohnsonpint should we also support short and the unsigned variants? |
Actually, now that I think about it, it should probably support any primitive or enum value. It shouldn't support other object types though, because they are tags. Complex objects don't make sense for tags. I'll make a small adjustment to this PR. |
Thanks all, I definitely agree that the primitive types make a ton of sense to be handled as tags in this way. I just wasn't sure if there were concerns with how Sentry.Extensions.Logging handled primitive types versus the other logging integrations, so I only included |
Having some issues with our PR validation pipeline, but this will be merged once resolved. Thanks. |
Adds support for all primitive types (long integers, etc.), and enums when converting objects to strings to be used for tags. Applies to the
SentyLogger
used bySentry.Extensions.Logging
and packages that depend on it such as ASP.NET Core.