Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix detection of .NET Framework 4.8.1 #1885

Merged
merged 2 commits into from
Aug 31, 2022
Merged

Fix detection of .NET Framework 4.8.1 #1885

merged 2 commits into from
Aug 31, 2022

Conversation

mattjohnsonpint
Copy link
Contributor

@mattjohnsonpint mattjohnsonpint commented Aug 31, 2022

Builds are failing because Github Actions runners now have .NET Framework 4.8.1 installed, and we don't have that in our version map.

Example failure:

https://github.com/getsentry/sentry-dotnet/runs/8105415270?check_suite_focus=true#step:6:556

Error: Expected string not to be <null>.

  Failed Sentry.Tests.PlatformAbstractions.RuntimeInfoTests.SetReleaseAndVersionNetFx_OnNetFx_NonNullReleaseAndVersion [13 ms]
  Error Message:
   Expected string not to be <null>.
  Stack Trace:
     at FluentAssertions.Execution.XUnit2TestFramework.Throw(String message)
   at FluentAssertions.Execution.AssertionScope.FailWith(Func`1 failReasonFunc)
   at FluentAssertions.Primitives.ReferenceTypeAssertions`2.NotBeNull(String because, Object[] becauseArgs)
   at Sentry.Tests.PlatformAbstractions.RuntimeInfoTests.SetReleaseAndVersionNetFx_OnNetFx_NonNullReleaseAndVersion() in D:\a\sentry-dotnet\sentry-dotnet\test\Sentry.Tests\PlatformAbstractions\RuntimeInfoTests.cs:line 51

@mattjohnsonpint
Copy link
Contributor Author

FYI, according to the official docs, the only build number we should expect is 533325. However, in this comment a user mentions 533320 is possible also. Not sure how to validate that, but there doesn't seem to be any harm in adding both.

@mattjohnsonpint mattjohnsonpint merged commit d8b2cbb into main Aug 31, 2022
@mattjohnsonpint mattjohnsonpint deleted the fix-netfx481 branch August 31, 2022 09:49
@mattjohnsonpint mattjohnsonpint mentioned this pull request Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants