Allow some mobile options to be modified from defaults #1857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
|
i like it. but did we not need to add/change any tests related to this? |
SimonCropp
reviewed
Aug 18, 2022
| @@ -179,7 +165,7 @@ private static void InitSentryAndroidSdk(SentryOptions options) | |||
| o.AddIgnoredExceptionForType(JavaClass.ForName("android.runtime.JavaProxyThrowable")); | |||
| })); | |||
|
|
|||
| // Set options for the managed SDK that depend on the Android SDK | |||
| // Set options for the managed SDK that depend on the Android SDK. (The user will not be able to modify these.) | |||
There was a problem hiding this comment.
The user will not be able to modify these
does this mean "there is no API what the user can use to modify these" or "we ignore/overwrite the options the user sets"?
There was a problem hiding this comment.
It means, we set these options ourselves during init, ignoring whatever the user provided. These should be limited to what is needed to make the native and managed SDKs work together.
Not until we have ability to write tests for ios/android |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Android, iOS, and MacCatalyst (and Windows if using MAUI):
DetectStartupTimeshould default toFast(notBest), but should be allowed to set toNoneAutoSessionTrackingshould betrueby default, but should be allowed to set tofalseIsGlobalModeEnabledshould always betrueand not allowed to be changed.Additionally:
__IOS__covers both iOS and MacCatalyst,__MOBILE__covers those plus AndroidSentrySdk.Initmethods that took an AndroidContextparameter, since we can get the application context directly.