-
-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS native support #1727
iOS native support #1727
Conversation
Instructions and example for changelogPlease add an entry to Example: - iOS native support ([#1727](https://github.com/getsentry/sentry-dotnet/pull/1727)) If none of the above apply, you can opt out of this check by adding |
…os-bindings #the commit.
4e754a1
to
ee90f56
Compare
@@ -5,7 +5,7 @@ | |||
<!-- BG8605 and BG8606 happen because there's a missing androidx.lifecycle dependency, but we don't need it here. (The native Android Sentry SDK will use it if it exists.) --> | |||
<NoWarn>$(NoWarn);BG8605;BG8606</NoWarn> | |||
<SentryAndroidSdkVersion>6.0.0</SentryAndroidSdkVersion> | |||
<AndroidLibsDirectory>$(BaseIntermediateOutputPath)\libs\Android\</AndroidLibsDirectory> | |||
<AndroidLibsDirectory>$(BaseIntermediateOutputPath)\SentrySDKs\Android\$(SentryAndroidSdkVersion)\</AndroidLibsDirectory> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocked by: dotnet/msbuild#4584
|
Blocked on: xamarin/xamarin-macios#15299 |
// o.Debug = options.Debug; | ||
// }); | ||
|
||
SentrySDK.CaptureMessage("Testing binding to iOS"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works (this event came from sentry-cocoa
):
Stack trace looks like that because we don't upload symbols yet on build
EventNotSent = 107 | ||
} | ||
|
||
//static class CFunctions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why the commented out code?
@@ -0,0 +1,1273 @@ | |||
using System; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this file code-gen'd?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, Objective Sharpie
Closing in favor of #1829. I used a lot of this though. Thanks!!! |
Hopefully one day: Resolves #1282