Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS native support #1727

Closed
wants to merge 16 commits into from
Closed

iOS native support #1727

wants to merge 16 commits into from

Conversation

bruno-garcia
Copy link
Member

@bruno-garcia bruno-garcia commented Jun 16, 2022

Hopefully one day: Resolves #1282

@github-actions
Copy link
Contributor

github-actions bot commented Jun 16, 2022

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

- iOS native support ([#1727](https://github.com/getsentry/sentry-dotnet/pull/1727))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 6d6032d

@@ -5,7 +5,7 @@
<!-- BG8605 and BG8606 happen because there's a missing androidx.lifecycle dependency, but we don't need it here. (The native Android Sentry SDK will use it if it exists.) -->
<NoWarn>$(NoWarn);BG8605;BG8606</NoWarn>
<SentryAndroidSdkVersion>6.0.0</SentryAndroidSdkVersion>
<AndroidLibsDirectory>$(BaseIntermediateOutputPath)\libs\Android\</AndroidLibsDirectory>
<AndroidLibsDirectory>$(BaseIntermediateOutputPath)\SentrySDKs\Android\$(SentryAndroidSdkVersion)\</AndroidLibsDirectory>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less relevant on Android because artifacts have the version on the file name, but puts things under the version to avoid issues when we update:

image

@bruno-garcia
Copy link
Member Author

bruno-garcia commented Jun 18, 2022

Blocked by: dotnet/msbuild#4584

dotnet pack fails with:

/usr/local/share/dotnet/sdk/6.0.301/Sdks/NuGet.Build.Tasks.Pack/buildCrossTargeting/NuGet.Build.Tasks.Pack.targets(221,5): error NU5026: The file '/Users/bruno/git/sentry-dotnet/src/Sentry/bin/Debug/net6.0-ios/Native.Sentry.manifest' to be packed was not found on disk. [/Users/bruno/git/sentry-dotnet/src/Sentry/Sentry.csproj]

@bruno-garcia
Copy link
Member Author

Blocked on: xamarin/xamarin-macios#15299

// o.Debug = options.Debug;
// });

SentrySDK.CaptureMessage("Testing binding to iOS");
Copy link
Member Author

@bruno-garcia bruno-garcia Jun 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works (this event came from sentry-cocoa):

image

Stack trace looks like that because we don't upload symbols yet on build

EventNotSent = 107
}

//static class CFunctions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the commented out code?

@@ -0,0 +1,1273 @@
using System;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this file code-gen'd?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattjohnsonpint mattjohnsonpint self-assigned this Jul 13, 2022
@mattjohnsonpint
Copy link
Contributor

Closing in favor of #1829. I used a lot of this though. Thanks!!!

@bruno-garcia bruno-garcia deleted the feat/ios-bindings branch July 30, 2022 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.NET 6 iOS support
3 participants