Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Android Support #1669

Merged
merged 7 commits into from
May 24, 2022
Merged

Update Android Support #1669

merged 7 commits into from
May 24, 2022

Conversation

mattjohnsonpint
Copy link
Contributor

@mattjohnsonpint mattjohnsonpint commented May 24, 2022

Adds on to #1288 with the following:

  • Fixes the Maven URLs for the DownloadSentryAndroidSdk custom build task.
    • The old ones failed with 403 Forbidden
  • Updates the Sentry Android/Java SDKs, and Google GSON dependency, to their latest versions.
    • Sentry Android/Java 5.3.0 -> 5.7.4
    • Google GSON 2.8.5 -> 2.9.0.1
  • Removes the custom NET6_0_ANDROID_OR_GREATER directive in favor of just ANDROID
    • We can always combine with NET6_0_OR_GREATER if we need to, but we don't need to yet.
  • Configures Sentry to add the io.sentry.auto-init (false) metadata to AndroidManifest.xml files automagically.

@mattjohnsonpint mattjohnsonpint merged commit 0d4a4dd into main May 24, 2022
@mattjohnsonpint mattjohnsonpint deleted the update-android branch May 24, 2022 22:42
@bruno-garcia
Copy link
Member

Gson 2.9.0 has compat issues with the Android SDK. Maybe @marandaneto can expand

// Don't let the Sentry Android SDK auto-init, as we do that manually in SentrySdk.Init
// See https://docs.sentry.io/platforms/android/configuration/manual-init/
// This attribute automatically adds the metadata to the final AndroidManifest.xml
[assembly: Android.App.MetaData("io.sentry.auto-init", Value = "false")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants