Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tunnel functionality into into Sentry.AspNetCore #1645

Merged
merged 16 commits into from
May 25, 2022

Conversation

SimonCropp
Copy link
Contributor

@SimonCropp SimonCropp commented May 6, 2022

  • Copies SentryTunnelMiddleware into Sentry.AspNetCore
  • Adds a nuget dependency from Sentry.Tunnel to Sentry.AspNetCore
  • Stubs out the old Sentry.Tunnel.SentryTunnelMiddleware by inheriting from Sentry.AspNetCore.SentryTunnelMiddleware
  • Obsoletes Sentry.Tunnel.SentryTunnelMiddleware
  • Merges Sentry.Tunnel.Tests into Sentry.AspNetCore.Tests
  • Removes [Collection("SentryTunnelCollection")] from IntegrationsTests
  • Copies extension methods from SentryTunnelingApplicationBuilderExtensions into SentryWebHostBuilderExtensions
  • Redirects method in SentryTunnelingApplicationBuilderExtensions to SentryWebHostBuilderExtensions
  • Obsoletes SentryTunnelingApplicationBuilderExtensions and points to SentryWebHostBuilderExtensions
  • Obsolete Sentry.Tunnel on nuget.

fixes #1141

@SimonCropp
Copy link
Contributor Author

SimonCropp commented May 6, 2022

Questions

  • @bruno-garcia what did [Collection("SentryTunnelCollection")] do?
  • If we want the tunnel host build API, i will need help. I failed to reverse engineer that code
  • Why is SentryTunnelMiddleware public?
  • @mattjohnsonpint i thought you already updated the docs related to tunneling?

@mattjohnsonpint
Copy link
Contributor

nope

@mattjohnsonpint mattjohnsonpint marked this pull request as draft May 10, 2022 20:49
@bruno-garcia
Copy link
Member

We can add the NuGet package obsolete on the gallery once we ship this.

@SimonCropp
Copy link
Contributor Author

@mattjohnsonpint @bruno-garcia one complexity of this is for people using Sentry.AspNet (non core). shouldnt they using tunnel as well?

@SimonCropp SimonCropp marked this pull request as ready for review May 21, 2022 02:07
@mattjohnsonpint
Copy link
Contributor

Tunneling is useful, but completely optional. We didn't have a ASP.NET (non-core) tunnel before, so it's not an issue at the moment. If it becomes higher priority, we could consider adding one to Sentry.AspNet later.

@mattjohnsonpint mattjohnsonpint merged commit b74b2ed into main May 25, 2022
@mattjohnsonpint mattjohnsonpint deleted the move-Tunnel-into-aspnetcore branch May 25, 2022 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvements for Sentry.Tunnel
3 participants