-
-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add new Protocol for DebugImages and AddressMode #1513
Conversation
Instructions and example for changelogPlease add an entry to Example: - Add new Protocol for DebugImages and AddressMode ([#1513](https://github.com/getsentry/sentry-dotnet/pull/1513)) If none of the above apply, you can opt out of this check by adding |
@SimonCropp is this PR just missing the verify snapshots? |
@Swatinem sorry for the hassle. You can read about Verify here https://github.com/VerifyTests/Verify For now i have accepted the changes in the pending snaphots. those api changes are configured to autoverify. so if you run all the tests, you should notice those files being updated in your git tooling. As for getting you setup and more familiar with snapshot testing. lets chat on discord |
Codecov Report
@@ Coverage Diff @@
## main #1513 +/- ##
==========================================
- Coverage 84.34% 83.87% -0.48%
==========================================
Files 219 220 +1
Lines 7423 7435 +12
Branches 1417 1426 +9
==========================================
- Hits 6261 6236 -25
- Misses 735 764 +29
- Partials 427 435 +8
Continue to review full report at Codecov.
|
Seems flaky? It used to pass before the merge. |
It was once before so might be again: #743 |
No description provided.