Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use delegate for transaction name #1444

Merged

Conversation

SimonCropp
Copy link
Contributor

what are peoples thoughts on using a delegate instead of an interface? it is less code for consumers and also more versatile since it can be defined inline

@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2022

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

- Use delegate for transaction name ([#1444](https://github.com/getsentry/sentry-dotnet/pull/1444))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 7f76c55

@lucas-zimerman lucas-zimerman merged commit 0c3ba11 into feat/remove-unknown-route Jan 21, 2022
@lucas-zimerman lucas-zimerman deleted the use-delegate-for-transaction-name branch January 21, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants