-
-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added ByteAttachmentContent #1384
Conversation
|
Running build.sh or build.ps1 should update the API changes on your local branch. |
I wonder if it's worth adding a GHA that does the diff and commits to the branch |
i disagree. the point of the api verification is to get people to view the changes and confirm they are correct. if we are going to automate the accepting of a new api, we may as well not have that step at all |
@bitsandfoxes Today @SimonCropp shared with us that it's possible the verify files were nto written because the tests didn't run for that specific runtime. Do you have .NET Core 2.1 installed? It should run the tests on that target and create the file that @SimonCropp pushed to your branch: |
Codecov Report
@@ Coverage Diff @@
## main #1384 +/- ##
==========================================
- Coverage 82.73% 81.27% -1.47%
==========================================
Files 215 216 +1
Lines 7165 7172 +7
Branches 1410 1410
==========================================
- Hits 5928 5829 -99
- Misses 802 917 +115
+ Partials 435 426 -9
Continue to review full report at Codecov.
|
I did not, but I do now. Thank for fixing my PR @bruno-garcia @SimonCropp |
Adding a byte array as an attachment and then trying to send events can lead to
System.ObjectDisposedException: Cannot access a closed Stream.
So instead of relying on one
stream
we create anew MemoryStream
every time the stream gets requested.The issue persists when trying to attach a stream.