Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache envelope headers #1242

Merged
merged 10 commits into from
Oct 11, 2021
Merged

Cache envelope headers #1242

merged 10 commits into from
Oct 11, 2021

Conversation

SimonCropp
Copy link
Contributor

  • the sdk header can always be re-used. No need to spin up a new dictionary every time
  • when there is no eventId then a static "default header" can be used.

@SimonCropp SimonCropp changed the title cache envelope headers Cache envelope headers Oct 6, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2021

Codecov Report

Merging #1242 (03be359) into main (71ff2ef) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1242      +/-   ##
==========================================
+ Coverage   80.59%   80.60%   +0.01%     
==========================================
  Files         212      212              
  Lines        6904     6908       +4     
  Branches     1587     1587              
==========================================
+ Hits         5564     5568       +4     
  Misses        809      809              
  Partials      531      531              
Impacted Files Coverage Δ
src/Sentry/Envelopes/Envelope.cs 95.18% <100.00%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71ff2ef...03be359. Read the comment docs.

CHANGELOG.md Show resolved Hide resolved
src/Sentry/Envelopes/Envelope.cs Outdated Show resolved Hide resolved
src/Sentry/Envelopes/Envelope.cs Outdated Show resolved Hide resolved
SimonCropp and others added 4 commits October 9, 2021 09:39
Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
@SimonCropp
Copy link
Contributor Author

@lucas-zimerman all changes applied

@SimonCropp SimonCropp merged commit 262b920 into main Oct 11, 2021
@SimonCropp SimonCropp deleted the cacheEnvelopeHeaders branch October 11, 2021 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants