Fix max breadcrumbs limit when MaxBreadcrumbs is zero or lower #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1145 +/- ##
=======================================
Coverage 80.58% 80.58%
=======================================
Files 203 203
Lines 6674 6675 +1
Branches 1476 1477 +1
=======================================
+ Hits 5378 5379 +1
Misses 816 816
Partials 480 480
Continue to review full report at Codecov.
|
Tyrrrz
approved these changes
Jul 26, 2021
bruno-garcia
approved these changes
Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it didn't matter the MaxBreadcrumb value, it would always be able to insert at least one breadcrumb because
_breadcrumbs.Enqueue(breadcrumb);was out of any validation.Close #1110.