-
-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ReportAssembliesMode in favor of ReportAssemblies #1079
Add ReportAssembliesMode in favor of ReportAssemblies #1079
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect. Thanks!
Please add an entry to Example:
|
Done, thanks for the fast review! |
Seems like we have some failing tests @GeertvanHorrik Can you repro them locally if you run all tests? |
That's my bad, sorry. I though returning string.Empty is better than null to prevent potential null reference exceptions. Will fix. |
Turning the tests back into their original behavior, but I am not sure if they are correct. At the moment, the informational version returns string.Empty (""), and that is being respected as null version. But I think it should fallback to the real assembly version in such case? Maybe that's something to think about for a separate ticket. I will revert the old behavior back and respect a string.empty return from the informational version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spotted one thing we might need to change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for adding more comments but I think we should consider one more thing
@GeertvanHorrik Thanks for your contributions. I'll change the minor items I suggested and release it |
Fixes #1072
Introduces the InformationalVersionAttribute in favor of ReportAssemblies, covered by unit tests.
A few additional changes:
Technically the GetName() can be optimized inside the foreach loop (only needed when value = in the MainSentryEventProcessor, but wasn't sure if it was worth less-readable code vs this optimization. Let me know if you would like this to be changed. For now this value is also used to determine whether an assembly should be checked / added at all.
Looking forward to your review. Have a great day!