Skip to content

Create release & set commits missing --org parameter #3595

Closed

Description

Package

Sentry.AspNetCore

.NET Flavor

.NET Core

.NET Version

8.0.8

OS

Windows

SDK Version

4.10.2

Self-Hosted Sentry Version

No response

Steps to Reproduce

  1. Add Sentry.AspNetCore 4.10.2 to project.
  2. Run dotnet build -v d "RealTime.API.csproj" -c Release -o /app/build -p:SentryOrg=propflo-ltd -p:SentryProject=realtime-api -p:SentryUploadSymbols=true -p:SentryUploadSources=true -p:SentryCreateRelease=true -p:SentrySetCommits=true

Setting Sentry params in the .csproj has the same issue.

Expected Result

A release is created with commits set.

Actual Result

The generated CLI commands are missing the --org parameter so the steps fail.

Looking through the targets file it looks like SentryReleaseOptions never has --org set like SentryCLIUploadOptions. I can raise a PR if the resolution is as simple as that.

Trimmed dotnet build output

Target "_GetSentryRelease" skipped, due to false condition; ('$(SentryCreateRelease)' == 'true' And '$(UseSentryCLI)' == 'true') was evaluated as ('true' == 'true' And '' == 'true').
       Target "_CheckBrowserWorkloadNeededButNotAvailable" skipped, due to false condition; ('$(RuntimeIdentifier)' == 'browser-wasm' and '$(_BrowserWorkloadDisabled)' != 'true' and '$(WasmNativeWorkloadAvailable)' != 'true') was evaluated as ('' == 'browser-wasm' and  
       '' != 'true' and '' != 'true').
       Target "_ErrorWorkloadDisabledForTFMLessThan6" skipped, due to false condition; ('$(_BrowserWorkloadNotSupportedForTFM)' == 'true') was evaluated as ('' == 'true').
       Target "_ErrorDualWasmThreadPropsOn7" skipped, due to false condition; ('$(TargetsNet7)' == 'true' and '$(RuntimeIdentifier)' == 'browser-wasm' and
           '$(BrowserWorkloadDisabled)' != 'true' and '$(WasmEnableThreads)' == 'true' and '$(WasmEnablePerfTrace)' == 'true') was evaluated as ('' == 'true' and '' == 'browser-wasm' and
           '' != 'true' and '' == 'true' and '' == 'true').
       Target "_CheckForInvalidConfigurationAndPlatform" skipped. Previously built successfully.
       Target "_CheckForInvalidConfigurationAndPlatform" skipped. Previously built successfully.
       Target "_GenerateOpenApiDocuments" skipped, due to false condition; ( '$(OpenApiGenerateDocumentsOnBuild)' == 'true' AND ('$(TargetFramework)' == '' OR '$(TargetFrameworks)' == '') ) was evaluated as ( 'false' == 'true' AND ('net8.0' == '' OR '' == '') ).        
       Target "_RefitMSBuildVersionCheck" skipped, due to false condition; ( '$([System.Version]::Parse($(_RefitMSBuildMinVersion)).CompareTo($([System.Version]::Parse($(MSBuildVersion)))))' > '0' ) was evaluated as ( '-1' > '0' ).
       Target "_RefitProjectRestoreTypeCheck" skipped. Previously built successfully.
   1:7>Target "Build" in file "C:\Program Files\dotnet\sdk\8.0.401\Microsoft.Common.CurrentVersion.targets" from project "C:\propflo\realtime-api\src\RealTime.API\RealTime.API.csproj" (entry point):
   1:7>Done building target "Build" in project "RealTime.API.csproj".
   1:7>Target "CheckSentryCLI" in file "C:\Users\Ben\.nuget\packages\sentry\4.10.2\buildTransitive\Sentry.targets" from project "C:\propflo\realtime-api\src\RealTime.API\RealTime.API.csproj" (entry point):
   1:7>Done building target "CheckSentryCLI" in project "RealTime.API.csproj".
   1:7>Target "PrepareSentryCLI" in file "C:\Users\Ben\.nuget\packages\sentry\4.10.2\buildTransitive\Sentry.targets" from project "C:\propflo\realtime-api\src\RealTime.API\RealTime.API.csproj" (entry point):
       Using "Exec" task from assembly "Microsoft.Build.Tasks.Core, Version=15.1.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a".
       Task "Exec"
         "C:\Users\Ben\.nuget\packages\sentry\4.10.2\tools\sentry-cli-Windows-x86_64.exe" info --no-defaults
         Sentry Server: https://sentry.io

         Authentication Info:
           Method: Auth Token
           User: ben@propflo.co.uk
           Scopes:
             - org:read
             - project:releases
       Done executing task "Exec".
       Task "Warning" skipped, due to false condition; ('$(_SentryCLIRequestFailed)' != '') was evaluated as ('' != '').
       Task "Message" skipped, due to false condition; ('$(_SentryCLIExitCode)' != '0' And '$(_SentryCLIRequestFailed)' == '') was evaluated as ('0' != '0' And '' == '').
       Task "Warning" skipped, due to false condition; ('$(SentryUploadSources)' == 'true' And '$(EmbedAllSources)' == 'true') was evaluated as ('true' == 'true' And '' == 'true').
   1:7>Done building target "PrepareSentryCLI" in project "RealTime.API.csproj".
       Target "PrepareSentryCLI" skipped. Previously built successfully.
   1:7>Target "UploadDebugInfoToSentry" in file "C:\Users\Ben\.nuget\packages\sentry\4.10.2\buildTransitive\Sentry.targets" from project "C:\propflo\realtime-api\src\RealTime.API\RealTime.API.csproj" (entry point):
       Task "Message"
         Preparing upload to Sentry for project 'RealTime.API' (Release/net8.0): collecting debug symbols and referenced source code from C:\app\build
       Done executing task "Message".
       Task "Exec"
         "C:\Users\Ben\.nuget\packages\sentry\4.10.2\tools\sentry-cli-Windows-x86_64.exe" debug-files upload --org propflo-ltd --project realtime-api -t pdb -t portablepdb --include-sources C:\app\build
         > Found 4 debug information files (4 with embedded sources)
         > Resolved source code for 0 debug information files
         > Prepared debug information files for upload
         > Uploaded 1 missing debug information file
         > File upload complete:

           UPLOADED 6fd73163-065a-4394-ab09-637500be77fe-fc9357c8 (RealTime.API.pdb;  debug companion)
       Done executing task "Exec".
       Task "Message" skipped, due to false condition; ('$(SentryUploadSymbols)' == 'true' and '$(SentryUploadSources)' != 'true') was evaluated as ('true' == 'true' and 'true' != 'true').
       Task "Exec" skipped, due to false condition; ('$(SentryUploadSymbols)' == 'true' and '$(SentryUploadSources)' != 'true') was evaluated as ('true' == 'true' and 'true' != 'true').
       Task "Message" skipped, due to false condition; ('$(SentryUploadSymbols)' != 'true' and '$(SentryUploadSources)' == 'true') was evaluated as ('true' != 'true' and 'true' == 'true').
       Task "Exec" skipped, due to false condition; ('$(SentryUploadSymbols)' != 'true' and '$(SentryUploadSources)' == 'true') was evaluated as ('true' != 'true' and 'true' == 'true').
       Task "Warning" skipped, due to false condition; ('$(_SentryCLIExitCode)' != '0') was evaluated as ('0' != '0').
       Task "Exec" skipped, due to false condition; ('$(SentryUploadSymbols)' != 'true' and '$(SentryUploadSources)' == 'true' and '$(_SentryCLIExitCode)' == '0') was evaluated as ('true' != 'true' and 'true' == 'true' and '0' == '0').
       Task "Warning" skipped, due to false condition; ('$(_SentryCLIExitCode)' != '0') was evaluated as ('0' != '0').
   1:7>Done building target "UploadDebugInfoToSentry" in project "RealTime.API.csproj".
       Target "UploadAndroidProguardMappingFileToSentry" skipped, due to false condition; ('$(SentryCLI)' != '' and '$(SentryUploadAndroidProguardMapping)' == 'true' And '$(AndroidProguardMappingFile)' != '') was evaluated as ('C:\Users\Ben\.nuget\packages\sentry\4.10. 
       2\tools\sentry-cli-Windows-x86_64.exe' != '' and '' == 'true' And '' != '').
   1:7>Target "_GetSentryRelease" in file "C:\Users\Ben\.nuget\packages\sentry\4.10.2\buildTransitive\Sentry.targets" from project "C:\propflo\realtime-api\src\RealTime.API\RealTime.API.csproj" (target "_CreateSentryRelease" depends on it):
       Task "Message"
         Getting Sentry Release...
       Done executing task "Message".
       Initializing task factory "RoslynCodeTaskFactory" from assembly "C:\Program Files\dotnet\sdk\8.0.401\Microsoft.Build.Tasks.Core.dll".
       
       Compiling task source code
       C:\Program Files\dotnet\dotnet.exe "C:\Program Files\dotnet\sdk\8.0.401\Roslyn\bincore\csc.dll" /noconfig /reference:"C:\Program Files\dotnet\sdk\8.0.401\ref\Microsoft.Build.Framework.dll" /reference:"C:\Program Files\dotnet\sdk\8.0.401\ref\Microsoft.Build.Utili 
       ties.Core.dll" /reference:"C:\Program Files\dotnet\sdk\8.0.401\ref\mscorlib.dll" /reference:"C:\Program Files\dotnet\sdk\8.0.401\ref\netstandard.dll" /deterministic+ /nologo /optimize- /target:Library /out:C:\Users\Ben\AppData\Local\Temp\MSBuildTemp\tmpdf3270a7b 
       8e242358cd7e849248620a2.dll C:\Users\Ben\AppData\Local\Temp\MSBuildTemp\tmp0f75c8308e8445449749b96882e1129c.tmp /nostdlib+
       Using "SentryGetApplicationVersion" task from the task factory "Roslyn Code Task Factory".
       Task "SentryGetApplicationVersion"
         Loading assembly: obj\Release\net8.0\RealTime.API.dll
         Assembly loaded during TaskRun (InlineCode.SentryGetApplicationVersion): RealTime.API, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null (location: C:\propflo\realtime-api\src\RealTime.API\obj\Release\net8.0\RealTime.API.dll, MVID: b711bbf5-9dca-4127-b94c- 
         d2d0474f5142, AssemblyLoadContext: Assembly.LoadFile(C:\propflo\realtime-api\src\RealTime.API\obj\Release\net8.0\RealTime.API.dll))
         Getting assembly name...
         Assembly name: RealTime.API
         Reading AssemblyInformationalVersionAttribute...
         Failed to read informational version attribute
         Version: 1.0.0.0
         Compiling release information...
       Done executing task "SentryGetApplicationVersion".
       Task "Exec" skipped, due to false condition; ('$(_SentryRelease)' == '') was evaluated as ('RealTime.API@1.0.0.0' == '').
       Task "Message"
         Sentry Release: RealTime.API@1.0.0.0
       Done executing task "Message".
   1:7>Done building target "_GetSentryRelease" in project "RealTime.API.csproj".
   1:7>Target "_CreateSentryRelease" in file "C:\Users\Ben\.nuget\packages\sentry\4.10.2\buildTransitive\Sentry.targets" from project "C:\propflo\realtime-api\src\RealTime.API\RealTime.API.csproj" (entry point):
       Task "Message"
         Creating Sentry Release: RealTime.API@1.0.0.0
       Done executing task "Message".
       Task "Exec"
         "C:\Users\Ben\.nuget\packages\sentry\4.10.2\tools\sentry-cli-Windows-x86_64.exe" releases new 'RealTime.API@1.0.0.0'  --project realtime-api
   1:7>EXEC : warning : An organization ID or slug is required (provide with --org) [C:\propflo\realtime-api\src\RealTime.API\RealTime.API.csproj]
         The previous error was converted to a warning because the task was called with ContinueOnError=true.

         Add --log-level=[info|debug] or export SENTRY_LOG_LEVEL=[info|debug] to see more output.
         Please attach the full debug log to all bug reports.
         The command ""C:\Users\Ben\.nuget\packages\sentry\4.10.2\tools\sentry-cli-Windows-x86_64.exe" releases new 'RealTime.API@1.0.0.0'  --project realtime-api" exited with code 1.
       Done executing task "Exec".
   1:7>Done building target "_CreateSentryRelease" in project "RealTime.API.csproj".
       Target "_CreateSentryRelease" skipped. Previously built successfully.
   1:7>Target "_SentrySetCommits" in file "C:\Users\Ben\.nuget\packages\sentry\4.10.2\buildTransitive\Sentry.targets" from project "C:\propflo\realtime-api\src\RealTime.API\RealTime.API.csproj" (entry point):
       Task "Message"
         Setting Sentry commits
       Done executing task "Message".
       Task "Exec"
         "C:\Users\Ben\.nuget\packages\sentry\4.10.2\tools\sentry-cli-Windows-x86_64.exe" releases set-commits --auto 'RealTime.API@1.0.0.0'  --project realtime-api
   1:7>EXEC : warning : An organization ID or slug is required (provide with --org) [C:\propflo\realtime-api\src\RealTime.API\RealTime.API.csproj]
         The previous error was converted to a warning because the task was called with ContinueOnError=true.

         Add --log-level=[info|debug] or export SENTRY_LOG_LEVEL=[info|debug] to see more output.
         Please attach the full debug log to all bug reports.
         The command ""C:\Users\Ben\.nuget\packages\sentry\4.10.2\tools\sentry-cli-Windows-x86_64.exe" releases set-commits --auto 'RealTime.API@1.0.0.0'  --project realtime-api" exited with code 1.
       Done executing task "Exec".
   1:7>Done building target "_SentrySetCommits" in project "RealTime.API.csproj".
       Target "ExecuteToolsTarget" skipped, due to false condition; ('@(ToolsTarget)' != '') was evaluated as ('' != '').
       Target "_PackAsBuildAfterTarget" skipped, due to false condition; ('$(GeneratePackageOnBuild)' == 'true' AND '$(IsInnerBuild)' != 'true') was evaluated as ('false' == 'true' AND '' != 'true').
   1:7>Target "_CheckContainersPackage" in file "C:\Program Files\dotnet\sdk\8.0.401\Containers\build\Microsoft.NET.Build.Containers.targets" from project "C:\propflo\realtime-api\src\RealTime.API\RealTime.API.csproj" (entry point):
       Task "Warning" skipped, due to false condition; ($(_ContainerPackageIsPresent)
               and (
                 ($(_SdkCanPublishWeb) and $(_IsWebProject)) or
                 ($(_SdkCanPublishWorker) and $(_IsWorkerProject)) or
                 ($(_SdkCanPublishConsole) and '$(EnableSdkContainerSupport)' == 'true')
               )) was evaluated as (false
               and (
                 (True and true) or
                 (True and false) or
                 (True and 'true' == 'true')
               )).
   1:7>Done building target "_CheckContainersPackage" in project "RealTime.API.csproj"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    • Status

      Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions