fix: Fixed TimeZone naming in MonitorConfig (#3403)

getsentry · Jun 4, 2024 · aa60fc1 · aa60fc1
1 parent 5659e2f
commit aa60fc1
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 9 deletions.
diff --git a/src/Sentry/SentryMonitorOptions.cs b/src/Sentry/SentryMonitorOptions.cs
@@ -164,7 +164,7 @@ public int? RecoveryThreshold
     /// <summary>
     /// A tz database string representing the timezone which the monitor's execution schedule is in (i.e. "America/Los_Angeles").
     /// </summary>
-    public string? Timezone { get; set; }
+    public string? TimeZone { get; set; }
 
     /// <summary>
     /// An actor identifier string. This looks like 'user:john@example.com team:a-sentry-team'. IDs can also be used but will result in a poor DX.
@@ -206,7 +206,7 @@ public void WriteTo(Utf8JsonWriter writer, IDiagnosticLogger? logger)
         writer.WriteNumberIfNotNull("max_runtime", MaxRuntime?.TotalMinutes);
         writer.WriteNumberIfNotNull("failure_issue_threshold", FailureIssueThreshold);
         writer.WriteNumberIfNotNull("recovery_threshold", RecoveryThreshold);
-        writer.WriteStringIfNotWhiteSpace("timezone", Timezone);
+        writer.WriteStringIfNotWhiteSpace("timezone", TimeZone);
         writer.WriteStringIfNotWhiteSpace("owner", Owner);
 
         writer.WriteEndObject();

diff --git a/test/Sentry.Tests/ApiApprovalTests.Run.DotNet6_0.verified.txt b/test/Sentry.Tests/ApiApprovalTests.Run.DotNet6_0.verified.txt
@@ -638,7 +638,7 @@ namespace Sentry
         public System.TimeSpan? MaxRuntime { get; set; }
         public string? Owner { get; set; }
         public int? RecoveryThreshold { get; set; }
-        public string? Timezone { get; set; }
+        public string? TimeZone { get; set; }
         public void Interval(string crontab) { }
         public void Interval(int interval, Sentry.SentryMonitorInterval unit) { }
         public void WriteTo(System.Text.Json.Utf8JsonWriter writer, Sentry.Extensibility.IDiagnosticLogger? logger) { }

diff --git a/test/Sentry.Tests/ApiApprovalTests.Run.DotNet7_0.verified.txt b/test/Sentry.Tests/ApiApprovalTests.Run.DotNet7_0.verified.txt
@@ -638,7 +638,7 @@ namespace Sentry
         public System.TimeSpan? MaxRuntime { get; set; }
         public string? Owner { get; set; }
         public int? RecoveryThreshold { get; set; }
-        public string? Timezone { get; set; }
+        public string? TimeZone { get; set; }
         public void Interval(string crontab) { }
         public void Interval(int interval, Sentry.SentryMonitorInterval unit) { }
         public void WriteTo(System.Text.Json.Utf8JsonWriter writer, Sentry.Extensibility.IDiagnosticLogger? logger) { }

diff --git a/test/Sentry.Tests/ApiApprovalTests.Run.DotNet8_0.verified.txt b/test/Sentry.Tests/ApiApprovalTests.Run.DotNet8_0.verified.txt
@@ -639,7 +639,7 @@ namespace Sentry
         public System.TimeSpan? MaxRuntime { get; set; }
         public string? Owner { get; set; }
         public int? RecoveryThreshold { get; set; }
-        public string? Timezone { get; set; }
+        public string? TimeZone { get; set; }
         public void Interval(string crontab) { }
         public void Interval(int interval, Sentry.SentryMonitorInterval unit) { }
         public void WriteTo(System.Text.Json.Utf8JsonWriter writer, Sentry.Extensibility.IDiagnosticLogger? logger) { }

diff --git a/test/Sentry.Tests/ApiApprovalTests.Run.Net4_8.verified.txt b/test/Sentry.Tests/ApiApprovalTests.Run.Net4_8.verified.txt
@@ -636,7 +636,7 @@ namespace Sentry
         public System.TimeSpan? MaxRuntime { get; set; }
         public string? Owner { get; set; }
         public int? RecoveryThreshold { get; set; }
-        public string? Timezone { get; set; }
+        public string? TimeZone { get; set; }
         public void Interval(string crontab) { }
         public void Interval(int interval, Sentry.SentryMonitorInterval unit) { }
         public void WriteTo(System.Text.Json.Utf8JsonWriter writer, Sentry.Extensibility.IDiagnosticLogger? logger) { }

diff --git a/test/Sentry.Tests/SentryClientTests.cs b/test/Sentry.Tests/SentryClientTests.cs
@@ -1304,7 +1304,7 @@ public void CaptureCheckIn_CheckInOptionsProvided_CheckInHasOptions()
             MaxRuntime = TimeSpan.FromMinutes(1),
             FailureIssueThreshold = 1,
             RecoveryThreshold = 1,
-            Timezone = "America/Los_Angeles",
+            TimeZone = "America/Los_Angeles",
             Owner = "test-owner"
         };
 
@@ -1314,7 +1314,7 @@ public void CaptureCheckIn_CheckInOptionsProvided_CheckInHasOptions()
             options.MaxRuntime = monitorOptions.MaxRuntime;
             options.FailureIssueThreshold = monitorOptions.FailureIssueThreshold;
             options.RecoveryThreshold = monitorOptions.RecoveryThreshold;
-            options.Timezone = monitorOptions.Timezone;
+            options.TimeZone = monitorOptions.TimeZone;
             options.Owner = monitorOptions.Owner;
         });
 
@@ -1325,7 +1325,7 @@ public void CaptureCheckIn_CheckInOptionsProvided_CheckInHasOptions()
         Assert.Equal(actualCheckIn.MonitorOptions.MaxRuntime, monitorOptions.MaxRuntime);
         Assert.Equal(actualCheckIn.MonitorOptions.FailureIssueThreshold, monitorOptions.FailureIssueThreshold);
         Assert.Equal(actualCheckIn.MonitorOptions.RecoveryThreshold, monitorOptions.RecoveryThreshold);
-        Assert.Equal(actualCheckIn.MonitorOptions.Timezone, monitorOptions.Timezone);
+        Assert.Equal(actualCheckIn.MonitorOptions.TimeZone, monitorOptions.TimeZone);
         Assert.Equal(actualCheckIn.MonitorOptions.Owner, monitorOptions.Owner);
     }