Skip to content

fix: Breadcrumb levels match event #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2019
Merged

fix: Breadcrumb levels match event #835

merged 1 commit into from
Mar 13, 2019

Conversation

bruno-garcia
Copy link
Member

No description provided.

@bruno-garcia bruno-garcia requested a review from HazAT March 12, 2019 13:09
@untitaker
Copy link
Member

@mitsuhiko we should fix this in semaphore I think

@bruno-garcia
Copy link
Member Author

@untitaker This is how it's named in `semaphore: https://github.com/getsentry/semaphore/blob/331b97bd3c6b7d5ea754aaa75b8e1c4083da86c0/general/src/protocol/types.rs#L513-L519

@mitsuhiko
Copy link
Contributor

We should fix the docs and also add support for the critical value in semaphore to be an alias.

@bruno-garcia bruno-garcia mentioned this pull request Mar 12, 2019
Merged
@bruno-garcia bruno-garcia merged commit 566bc08 into master Mar 13, 2019
@bruno-garcia bruno-garcia deleted the fix/sdk-dev-crumb-level branch March 13, 2019 12:21
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@untitaker untitaker untitaker approved these changes

@HazAT HazAT Awaiting requested review from HazAT

@mitsuhiko mitsuhiko Awaiting requested review from mitsuhiko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bruno-garcia @untitaker @mitsuhiko